Skip to content

perf_hooks: fix_performance_start_time#43069

Closed
theanarkh wants to merge 1 commit intonodejs:masterfrom
theanarkh:fix_performance_start_time
Closed

perf_hooks: fix_performance_start_time#43069
theanarkh wants to merge 1 commit intonodejs:masterfrom
theanarkh:fix_performance_start_time

Conversation

@theanarkh
Copy link
Contributor

@theanarkh theanarkh commented May 12, 2022 •
edited
Loading

fix start_time of perf_hooks

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 12, 2022

Review requested:

  • @nodejs/http
  • @nodejs/http2
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels May 12, 2022
@theanarkh theanarkh force-pushed the fix_performance_start_time branch from 85d6da4 to 1e4f816 Compare May 12, 2022 06:48
mcollina
mcollina approved these changes May 12, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lpinca
Copy link
Member

lpinca commented May 12, 2022

#43066 was opened first and seems simpler if it is still correct.

@theanarkh
Copy link
Contributor Author

theanarkh commented May 12, 2022 •
edited
Loading

#43066 was opened first and seems simpler if it is still correct.

yes, but i think the other modules such as http,http2 also have the same problem, so i fix them together. Maybe i do not modify the code of node_perf.cc which fix the #43062 in my branch.

@theanarkh theanarkh force-pushed the fix_performance_start_time branch 2 times, most recently from d2dd517 to 2a87c97 Compare May 15, 2022 01:59
@theanarkh theanarkh force-pushed the fix_performance_start_time branch 2 times, most recently from 4af2a8a to 6dd1c86 Compare May 18, 2022 11:19
@theanarkh theanarkh force-pushed the fix_performance_start_time branch from 6dd1c86 to 6a314e6 Compare May 18, 2022 13:32
@theanarkh
Copy link
Contributor Author

theanarkh commented May 18, 2022 •
edited
Loading

@mcollina @legendecas Hi, can this PR be merged ?

@legendecas legendecas added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels May 18, 2022
@legendecas
Copy link
Member

legendecas commented May 18, 2022

@theanarkh yeah, I think this PR is author ready. I'll trigger the full CI builds.

@theanarkh
Copy link
Contributor Author

theanarkh commented May 18, 2022

@theanarkh yeah, I think this PR is author ready. I'll trigger the full CI builds.

Thanks!

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 18, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 18, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/44071/

@github-actions github-actions bot mentioned this pull request May 19, 2022
Open
27 tasks
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 19, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/44076/

@github-actions github-actions bot mentioned this pull request May 20, 2022
Open
28 tasks
@theanarkh
Copy link
Contributor Author

theanarkh commented May 20, 2022

@mcollina @legendecas. Hi, can you help trigger CI again ? Thanks !

@github-actions github-actions bot mentioned this pull request May 21, 2022
Open
26 tasks
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 21, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/44101/

@github-actions github-actions bot mentioned this pull request May 22, 2022
Open
25 tasks
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 22, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/44120/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 22, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/44129/

This was referenced May 23, 2022
Open
Open
Open
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 25, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/44159/

RafaelGSS
RafaelGSS approved these changes May 25, 2022
View reviewed changes
Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@github-actions github-actions bot mentioned this pull request May 26, 2022
Open
19 tasks
@theanarkh
Copy link
Contributor Author

theanarkh commented May 26, 2022

@legendecas Hi, can you help merge this PR ? Thanks !

@legendecas
Copy link
Member

legendecas commented May 26, 2022

Landed in cb4a558

legendecas pushed a commit that referenced this pull request May 26, 2022
@theanarkh @legendecas
perf_hooks: fix start_time of perf_hooks
cb4a558 
PR-URL: #43069
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
@legendecas legendecas closed this May 26, 2022
This was referenced May 28, 2022
Open
Open
bengl pushed a commit that referenced this pull request May 30, 2022
@theanarkh @bengl
perf_hooks: fix start_time of perf_hooks
54d68b1 
PR-URL: #43069
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
@bengl bengl mentioned this pull request May 31, 2022
Merged
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
@theanarkh @danielleadams
perf_hooks: fix start_time of perf_hooks
17b5131 
PR-URL: #43069
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
targos pushed a commit that referenced this pull request Jul 12, 2022
@theanarkh @targos
perf_hooks: fix start_time of perf_hooks
65949fb 
PR-URL: #43069
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
targos pushed a commit that referenced this pull request Jul 31, 2022
@theanarkh @targos
perf_hooks: fix start_time of perf_hooks
8b0ae63 
PR-URL: #43069
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
@targos targos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@theanarkh @guangwong
perf_hooks: fix start_time of perf_hooks
80dec2c 
PR-URL: nodejs/node#43069
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes

@legendecas legendecas legendecas approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@theanarkh @nodejs-github-bot @lpinca @legendecas @mcollina @RafaelGSS