net: remoteAddress always undefined called before connected#43011
Closed
Y1D7NG wants to merge 1 commit intonodejs:masterfrom
Closed
net: remoteAddress always undefined called before connected#43011Y1D7NG wants to merge 1 commit intonodejs:masterfrom
Y1D7NG wants to merge 1 commit intonodejs:masterfrom
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
Contributor
|
Can you link that PR so I can take a look tomorrow? |
himself65
approved these changes
May 8, 2022
lpinca
approved these changes
May 8, 2022
Contributor
Author
|
can this be merged? |
Contributor
|
At least two approvals and 48 hours passed. I think we're good to go! |
github-actions
bot
removed
the
request-ci
Collaborator
27 tasks
Collaborator
Collaborator
Contributor
|
Landed in b88045f |
ShogunPanda
pushed a commit
that referenced
this pull request
May 19, 2022
PR-URL: #43011 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This was referenced May 20, 2022
bengl
pushed a commit
that referenced
this pull request
May 30, 2022
PR-URL: #43011 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Member
|
This seems to in break v16.x: make[1]: Leaving directory '/home/juanarbol/GitHub/node/test/node-api/test_worker_terminate/build'
/usr/bin/python3.10 tools/test.py --mode=release \
\
--skip-tests= \
default \
addons js-native-api node-api
=== release test-net-remote-address-port ===
Path: parallel/test-net-remote-address-port
node:assert:399
throw err;
^
AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:
assert.ok(remoteFamilyCandidates.includes(socket.remoteFamily))
at Server.<anonymous> (/home/juanarbol/GitHub/node/test/parallel/test-net-remote-address-port.js:38:10)
at Server.<anonymous> (/home/juanarbol/GitHub/node/test/common/index.js:417:15)
at Server.emit (node:events:527:28)
at TCP.onconnection (node:net:1634:8) {
generatedMessage: true,
code: 'ERR_ASSERTION',
actual: false,
expected: true,
operator: '=='
}not really sure why, I will label this one as backport-requested in the meantime |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #43009
connectingand get remote address, family and port, returnthis._peername || {}directly.remoteFamilyisIPvundefinedwhen it doesn't exis, returnundefinedif it does not exist.