src: delete AllocatedBuffer#43008
Merged
nodejs-github-bot merged 1 commit intonodejs:masterfrom May 13, 2022
Merged
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
Since all its uses are now gone, it's time to say goodbye to AllocatedBuffer. Refs: nodejs#39941 Signed-off-by: Darshan Sen <[email protected]>
RaisinTen
force-pushed
the
src/delete-AllocatedBuffer
branch
from
f57a0e5 to
eb2d258
Compare
Collaborator
tniessen
approved these changes
May 8, 2022
Trott
approved these changes
May 8, 2022
RaisinTen
added
the
author ready
VoltrexKeyva
approved these changes
May 8, 2022
jasnell
approved these changes
May 8, 2022
lpinca
approved these changes
May 8, 2022
himself65
approved these changes
May 9, 2022
addaleax
approved these changes
May 9, 2022
RaisinTen
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in f91dcc2 |
BethGriggs
pushed a commit
that referenced
this pull request
May 16, 2022
Since all its uses are now gone, it's time to say goodbye to AllocatedBuffer. Refs: #39941 Signed-off-by: Darshan Sen <[email protected]> PR-URL: #43008 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Zeyu "Alex" Yang <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Merged
juanarbol
pushed a commit
that referenced
this pull request
May 31, 2022
Since all its uses are now gone, it's time to say goodbye to AllocatedBuffer. Refs: #39941 Signed-off-by: Darshan Sen <[email protected]> PR-URL: #43008 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Zeyu "Alex" Yang <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jun 27, 2022
Since all its uses are now gone, it's time to say goodbye to AllocatedBuffer. Refs: #39941 Signed-off-by: Darshan Sen <[email protected]> PR-URL: #43008 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Zeyu "Alex" Yang <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jul 12, 2022
Since all its uses are now gone, it's time to say goodbye to AllocatedBuffer. Refs: #39941 Signed-off-by: Darshan Sen <[email protected]> PR-URL: #43008 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Zeyu "Alex" Yang <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
Since all its uses are now gone, it's time to say goodbye to AllocatedBuffer. Refs: #39941 Signed-off-by: Darshan Sen <[email protected]> PR-URL: #43008 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Zeyu "Alex" Yang <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
codebytere
added a commit
to electron/electron
that referenced
this pull request
Aug 25, 2022
codebytere
added a commit
to electron/electron
that referenced
this pull request
Aug 25, 2022
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
Since all its uses are now gone, it's time to say goodbye to AllocatedBuffer. Refs: nodejs/node#39941 Signed-off-by: Darshan Sen <[email protected]> PR-URL: nodejs/node#43008 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Zeyu "Alex" Yang <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since all its uses are now gone, it's time to say goodbye to
AllocatedBuffer.Refs: #39941
Signed-off-by: Darshan Sen [email protected]
cc @addaleax