http: add perf_hooks detail for http request and client

[theanarkh]

http: add perf_hooks detail

1. http: add perf_hooks detail for http request and client
2. dns,net: move hasObserver out of startPerf and stopPerf

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

Affected subsystem: http,net,dns

[nodejs-github-bot]

Review requested:

• @nodejs/http
• @nodejs/net

[mscdex]

Removing the conditionals is going to unnecessarily make more work on the GC when there are no observers because of the (inline) object being created for every request.

[theanarkh]

Removing the conditionals is going to unnecessarily make more work on the GC when there are no observers because of the (inline) object being created for every request.

Thanks for your review. do you mean hasObserver ? I have moved it to startPerf and stopPerf.

[mcollina]

Change looks good. We need the benchmarks run.

[theanarkh]

Change looks good. We need the benchmarks run.

Thanks for reply. I wonder what i need to do for benchmarking ?

[mscdex]

Thanks for your review. do you mean hasObserver ? I have moved it to startPerf and stopPerf.

Yes. Previously object creation was guarded by an if (hasObserver(..)) but now an object (for example: the one containing type, name, and detail) is created every time whether or not the observer is active.

[theanarkh]

Thanks for your review. do you mean hasObserver ? I have moved it to startPerf and stopPerf.

Yes. Previously object creation was guarded by an if (hasObserver(..)) but now an object (for example: the one containing type, name, and detail) is created every time whether or not the observer is active.

Thanks for your review. I have modified the code, please review again.

[theanarkh]

@mcollina @mscdex hi, can you please help review this PR again? thanks.

[mcollina]

lgtm

[theanarkh]

I will separate this PR to two PRs.