Conversation
saghul
added
the
libuv
|
Rubber stamp LGTM if the CI is happy. |
|
Merging this should fix #3718. |
|
LGTM if CI is green |
|
@seishun good catch, thanks. |
|
Is this the new way of Jenkins telling me the build is green? https://ci.nodejs.org/job/node-test-commit/1431/ |
|
@saghul yes, it looks like the only failures are known flakey tests on Windows. |
|
Oh, forgot to mention, we now have |
Fixes: nodejs#3718 PR-URL: nodejs#4276 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
|
Merged, thanks for the reviews! ❤️ |
Fixes: #3718 PR-URL: #4276 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Notable changes:
* domains:
- Fix handling of uncaught exceptions.
(Julien Gilli) #3654.
* https:
- Added support for disabling session caching.
(Fedor Indutny) #4252.
* repl:
- Allow third party modules to be imported using
require(). This corrects a regression from 5.2.0.
(Ben Noordhuis) #4215.
* deps:
- Upgrade libuv to 1.8.0.
(Saúl Ibarra Corretgé) #4276.
PR-URL: #4281
Notable changes:
* buffer:
- Buffer.prototype.includes() has been added to keep parity
with TypedArrays. (Alexander Martin) #3567.
* domains:
- Fix handling of uncaught exceptions.
(Julien Gilli) #3654.
* https:
- Added support for disabling session caching.
(Fedor Indutny) #4252.
* repl:
- Allow third party modules to be imported using
require(). This corrects a regression from 5.2.0.
(Ben Noordhuis) #4215.
* deps:
- Upgrade libuv to 1.8.0.
(Saúl Ibarra Corretgé) #4276.
PR-URL: #4281
Notable changes:
* buffer:
- Buffer.prototype.includes() has been added to keep parity
with TypedArrays. (Alexander Martin) #3567.
* domains:
- Fix handling of uncaught exceptions.
(Julien Gilli) #3654.
* https:
- Added support for disabling session caching.
(Fedor Indutny) #4252.
* repl:
- Allow third party modules to be imported using
require(). This corrects a regression from 5.2.0.
(Ben Noordhuis) #4215.
* deps:
- Upgrade libuv to 1.8.0.
(Saúl Ibarra Corretgé) #4276.
PR-URL: #4281
Conflicts:
src/node_version.h
|
Worth pulling in @nodejs/lts on this one, do we need to think on our policy re libuv & LTS or is case-by-case OK? It seems for this particular upgrade we get some AIX improvements and the fix for #4091 — please consider that issue, I can't work out whether it should be considered a rare edge-case or something that will come up now and again for Argon users. |
|
FWIW, libuv v1.x keeps a strict backwards API compatibility and ABI stability, so pulling in every v1.x release into LTS should never result in breakage. |
|
So long as there is no ABI breakage I've got no problem with that.
|
Fixes: #3718 PR-URL: #4276 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
|
I've landed this onto v4.x-staging. Here is a CI run to be safe --> https://ci.nodejs.org/job/node-test-commit/1636/ |
Fixes: #3718 PR-URL: #4276 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Fixes: nodejs#3718 PR-URL: nodejs#4276 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Notable changes:
* buffer:
- Buffer.prototype.includes() has been added to keep parity
with TypedArrays. (Alexander Martin) nodejs#3567.
* domains:
- Fix handling of uncaught exceptions.
(Julien Gilli) nodejs#3654.
* https:
- Added support for disabling session caching.
(Fedor Indutny) nodejs#4252.
* repl:
- Allow third party modules to be imported using
require(). This corrects a regression from 5.2.0.
(Ben Noordhuis) nodejs#4215.
* deps:
- Upgrade libuv to 1.8.0.
(Saúl Ibarra Corretgé) nodejs#4276.
PR-URL: nodejs#4281
Conflicts:
src/node_version.h
8 participants
R=@bnoordhuis
/cc @nodejs/collaborators
@rvagg items for release notes: