Skip to content

test: improve lib/internal/test_runner/test.js coverage#42745

Merged
nodejs-github-bot merged 1 commit intonodejs:masterfrom
fossamagna:test-test-runner-coverage
Apr 27, 2022
Merged

test: improve lib/internal/test_runner/test.js coverage#42745
nodejs-github-bot merged 1 commit intonodejs:masterfrom
fossamagna:test-test-runner-coverage

Conversation

@fossamagna
Copy link
Contributor

@fossamagna fossamagna commented Apr 15, 2022

This improves a test coverage in lib/internal/test_runner/test.js coveage

Ref: https://coverage.nodejs.org/coverage-24adba675179ebba/lib/internal/test_runner/test.js.html#L371

This validates that printing correctly error message when multiple subtests failed

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Apr 15, 2022
@aduh95 aduh95 requested a review from cjihrig April 15, 2022 12:34
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Apr 15, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 15, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 15, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/43519/

cjihrig
cjihrig approved these changes Apr 15, 2022
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but this has conflicts.

@fossamagna
Copy link
Contributor Author

fossamagna commented Apr 16, 2022

@cjihrig Thanks, I resolved conflicts.

@github-actions github-actions bot mentioned this pull request Apr 16, 2022
Open
16 tasks
cjihrig
cjihrig reviewed Apr 16, 2022
View reviewed changes
test/message/test_runner_output.out Outdated
duration_ms: *
failureType: 'testCodeFailure'
error: 'thrown from subtest sync throw fails at first'
code: ERR_TEST_FAILURE
Copy link
Contributor

@cjihrig cjihrig Apr 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I think the code fields here and below need to be in quotes now. The CI is probably going to fail because of it.

Copy link
Contributor Author

@fossamagna fossamagna Apr 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cjihrig Oops, I overlooked it. I changed to wrapping error code in single quotes. Thanks again.

@aduh95 aduh95 added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Apr 16, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 16, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/43529/

@aduh95
Copy link
Contributor

aduh95 commented Apr 16, 2022

@fossamagna can you please rebase on top of master? The merge commit is breaking the CI. Let me know if you help for that.

@lpinca
Copy link
Member

lpinca commented Apr 16, 2022

There is a typo in the first commit message: "coveage" -> coverage".

@fossamagna
Copy link
Contributor Author

fossamagna commented Apr 16, 2022

@aduh95 Sorry. I will rebase top of master in test-test-runner-coverage branch. Or Should I remake Pull Request in other branch?

@fossamagna fossamagna changed the title test: improve lib/internal/test_runner/test.js coveage test: improve lib/internal/test_runner/test.js coverage Apr 17, 2022
@fossamagna fossamagna force-pushed the test-test-runner-coverage branch from 330f986 to e9da7bf Compare April 17, 2022 00:12
@github-actions github-actions bot mentioned this pull request Apr 17, 2022
Open
15 tasks
@lpinca
Copy link
Member

lpinca commented Apr 17, 2022

@fossamagna you can force push on this PR branch.

@fossamagna
Copy link
Contributor Author

fossamagna commented Apr 17, 2022

@lpinca Thanks, I rebase and force push.

@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 17, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 17, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 17, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/43545/

@github-actions github-actions bot mentioned this pull request Apr 18, 2022
Open
14 tasks
@github-actions github-actions bot mentioned this pull request Apr 19, 2022
Open
16 tasks
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 19, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/43573/

@github-actions github-actions bot mentioned this pull request Apr 20, 2022
Open
16 tasks
@github-actions github-actions bot mentioned this pull request Apr 21, 2022
Open
22 tasks
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 21, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/43609/

This was referenced Apr 22, 2022
Open
Open
Open
Open
Open
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 26, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/43714/

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 27, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 27, 2022
@nodejs-github-bot nodejs-github-bot merged commit 8cbc390 into nodejs:master Apr 27, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 27, 2022

Landed in 8cbc390

@fossamagna fossamagna deleted the test-test-runner-coverage branch April 28, 2022 00:27
targos pushed a commit that referenced this pull request Apr 28, 2022
@fossamagna @targos
test: improve lib/internal/test_runner/test.js coverage
b85a11c 
PR-URL: #42745
Refs: https://coverage.nodejs.org/coverage-24adba675179ebba/lib/internal/test_runner/test.js.html#L371
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request May 2, 2022
Merged
@juanarbol
Copy link
Member

juanarbol commented May 30, 2022

Sadly, this is part of the built-in test-runner, which is not landed in v16.x

aduh95 pushed a commit to aduh95/node-core-test that referenced this pull request Jul 8, 2022
@fossamagna @aduh95
test: improve lib/internal/test_runner/test.js coverage
ba68062 
PR-URL: nodejs/node#42745
Refs: https://coverage.nodejs.org/coverage-24adba675179ebba/lib/internal/test_runner/test.js.html#L371
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit to aduh95/node-core-test that referenced this pull request Jul 9, 2022
@fossamagna @aduh95
test: improve lib/internal/test_runner/test.js coverage
626f33e 
PR-URL: nodejs/node#42745
Refs: https://coverage.nodejs.org/coverage-24adba675179ebba/lib/internal/test_runner/test.js.html#L371
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit to aduh95/node-core-test that referenced this pull request Jul 9, 2022
@fossamagna @aduh95
test: improve lib/internal/test_runner/test.js coverage
39cce8a 
PR-URL: nodejs/node#42745
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
@fossamagna @targos
test: improve lib/internal/test_runner/test.js coverage
c291233 
PR-URL: #42745
Refs: https://coverage.nodejs.org/coverage-24adba675179ebba/lib/internal/test_runner/test.js.html#L371
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@fossamagna @guangwong
test: improve lib/internal/test_runner/test.js coverage
3ef16b5 
PR-URL: nodejs/node#42745
Refs: https://coverage.nodejs.org/coverage-24adba675179ebba/lib/internal/test_runner/test.js.html#L371
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@aduh95 aduh95 aduh95 approved these changes

@marsonya marsonya marsonya approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@fossamagna @nodejs-github-bot @aduh95 @lpinca @juanarbol @jasnell @cjihrig @marsonya @targos