Skip to content

src: fix alphabetically sorted binding list#42687

Merged
nodejs-github-bot merged 1 commit intonodejs:masterfrom
tniessen:src-fix-order-in-binding-list
Apr 11, 2022
Merged

src: fix alphabetically sorted binding list#42687
nodejs-github-bot merged 1 commit intonodejs:masterfrom
tniessen:src-fix-order-in-binding-list

Conversation

@tniessen
Copy link
Member

@tniessen tniessen commented Apr 11, 2022

No description provided.

@tniessen tniessen added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 11, 2022
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Apr 11, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 11, 2022

Fast-track has been requested by @tniessen. Please 👍 to approve.

@Trott Trott added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Apr 11, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 11, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 11, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/43424/

@marsonya marsonya added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 11, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 11, 2022
@nodejs-github-bot nodejs-github-bot merged commit 75a71dc into nodejs:master Apr 11, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 11, 2022

Landed in 75a71dc

@BethGriggs BethGriggs mentioned this pull request Apr 11, 2022
Merged
xtx1130 pushed a commit to xtx1130/node that referenced this pull request Apr 25, 2022
@tniessen @xtx1130
src: fix alphabetically sorted binding list
0a6d52e 
PR-URL: nodejs#42687
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
juanarbol pushed a commit that referenced this pull request May 31, 2022
@tniessen @juanarbol
src: fix alphabetically sorted binding list
d5a7787 
PR-URL: #42687
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
@juanarbol juanarbol mentioned this pull request May 31, 2022
Closed
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
@tniessen @danielleadams
src: fix alphabetically sorted binding list
051100f 
PR-URL: #42687
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
targos pushed a commit that referenced this pull request Jul 11, 2022
@tniessen @targos
src: fix alphabetically sorted binding list
054e5a6 
PR-URL: #42687
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
targos pushed a commit that referenced this pull request Jul 31, 2022
@tniessen @targos
src: fix alphabetically sorted binding list
8687ba8 
PR-URL: #42687
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
@targos targos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@tniessen @guangwong
src: fix alphabetically sorted binding list
038fe8a 
PR-URL: nodejs/node#42687
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes

@cjihrig cjihrig cjihrig approved these changes

@richardlau richardlau richardlau approved these changes

@marsonya marsonya marsonya approved these changes

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

+1 more reviewer

@apapirovski apapirovski apapirovski approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@tniessen @nodejs-github-bot @apapirovski @Trott @cjihrig @richardlau @marsonya @VoltrexKeyva