src,crypto: adjust crypto_bio files for formatter/linter

[Trott]

Run clang-format on the files and provide needed additional comments for
the linter.

Refs: #42665 (comment)

[nodejs-github-bot]

Review requested:

• @nodejs/crypto

[Trott]

I find changes like this less readable and I'm guessing I'm not alone. (It further suggests to me that we don't actually use clang-format.) I imagine there's a configuration that could be changed in .clang-format if this is a highly-undesriable change (or we could add { and } which would presumably cause clang-format to leave the block on it's own line, although I haven't tested that).

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/43407/

[RaisinTen]

Instead of introducing changes purely to satisfy the linters, what do you think about setting up the clang-format linter on CI first? It should automatically suggest fixes for areas touched by newer PRs.

[Trott]

Instead of introducing changes purely to satisfy the linters, what do you think about setting up the clang-format linter on CI first? It should automatically suggest fixes for areas touched by newer PRs.

When you say "clang-format linter", do you mean something different than the clang-format Makefile task we have now? For CI, I had planned/imagined running the clang-format job and have it fail if it produced a diff (which is what the markdown formatter does--we run the markdown formatter as part of the markdown lint job and if it produces output that is different from what is in the files that were changed in the PR, it raises an error and tells the person to run the format-md task). That is something we should do. I'm not sure this or other PRs should wait necessarily. I imagine bikeshedding on the rules might take some time. There's #42668 (comment), and the likely bug in one of the rules around pointers/readability, and probably other things.

[Trott]

I had planned/imagined

Please don't let the "I had planned" part stop you or anyone else from doing this. I very well may never bother to do it.

[RaisinTen]

When you say "clang-format linter", do you mean something different than the clang-format Makefile task we have now?

I meant make format-cpp.

Please don't let the "I had planned" part stop you or anyone else from doing this. I very well may never bother to do it.

Sure, sent a PR to run it on CI - #42681.

[Trott]

@RaisinTen In your opinion, should I mark this as blocked on #42681? Close this entirely? Reduce this to just the changes that the linter needs? Something else?

[RaisinTen]

IMO, we should close this PR because landing #42681 should automatically help in fixing the formatting in newer PRs and running clang-format on these files manually would potentially cause more git conflicts and add another git-blame to the logs without much gain.