doc: fix `added:` info for some methods by lpinca · Pull Request #42661 · nodejs/node

lpinca · 2022-04-08T19:46:45Z

outgoingMessage.getHeader(), outgoingMessage.getHeaderNames(), and
outgoingMessage.getHeaders() were added to Node.js v7.7.0 via
3e8d43d.

nodejs-github-bot · 2022-04-08T19:46:49Z

Review requested:

@nodejs/http
@nodejs/net

ShogunPanda

LGTM

aduh95 · 2022-04-08T23:09:21Z

doc/api/http.md

+added:
+  - v8.0.0
+  - v7.7.0


So this feature landed on v7.7.0? Why do we want to add v8.0.0 on this list? I don't think that's an interesting addition, all features of v7.7.0 are on v8.0.0 (or we should list all releases that happen since v7.7.0).

Suggested change

added:

- v8.0.0

- v7.7.0

added: v7.7.0

No, the methods were added to v8.0.0 and backported to v7.7.0. See PR description and commit message.

We do the same for other backports.

Do you mean that since there are no "holes" it does not make sense to list v8.0.0? In that case I see your point but the info is a bit misleading.

There are other occurrences like this that we might want to fix if you have a strong opinion about this:

https://nodejs.org/api/cli.html#-c---check

https://nodejs.org/api/url.html#class-url

Personally, I think this is more correct.

Node.js 8.0.0 was released on 2017-05-30, Node.js 7.7.0 was released 3 months before that on 2017-02-28. I don't see how it's relevant to our user if the feature landed on the Current release line because of a backport or as a regular cherry-picking, the backport doesn't make it special IMO.

https://nodejs.org/api/url.html#class-url

That's different, Node.js v6.13.0 was a LTS release, so it makes sense to list it there as it first landed on v7.0.0.

https://nodejs.org/api/cli.html#-c---check

That's an interesting one, v4.2.0 is listed as an LTS release (with the --check change)

node/doc/changelogs/CHANGELOG_V4.md

Lines 3069 to 3077 in 86099a3

## 2015-10-07, Version 4.2.0 'Argon' (LTS), @jasnell

### Notable changes

The first Node.js LTS release! See <https://github.com/nodejs/LTS/> for details of the LTS process.

* **icu**: Updated to version 56 with significant performance improvements (Steven R. Loomis) [#3281](https://github.com/nodejs/node/pull/3281)

* **node**:

* Added new `-c` (or `--check`) command line argument for checking script syntax without executing the code (Dave Eddy) [#2411](https://github.com/nodejs/node/pull/2411)

So one could think that v5.0.0 was the Current release that landed first, but it looks like it was released after v4.2.0, and --check change is not listed on its changelog:

node/doc/changelogs/CHANGELOG_V5.md

Line 1591 in 86099a3

## 2015-10-29, Version 5.0.0 (Stable), @rvagg

So yes, I think we should fix that.

doc/api/http.md

mcollina

lgtm

`outgoingMessage.getHeader()`, `outgoingMessage.getHeaderNames()`, and `outgoingMessage.getHeaders()` were added to Node.js v7.7.0 via 3e8d43d.

mcollina

lgtm

nodejs-github-bot · 2022-04-11T05:21:49Z

Landed in 4508c8c

`outgoingMessage.getHeader()`, `outgoingMessage.getHeaderNames()`, and `outgoingMessage.getHeaders()` were added to Node.js v7.7.0 via 3e8d43d. PR-URL: nodejs#42661 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Qingyu Deng <i@ayase-lab.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>

`outgoingMessage.getHeader()`, `outgoingMessage.getHeaderNames()`, and `outgoingMessage.getHeaders()` were added to Node.js v7.7.0 via 3e8d43d. PR-URL: #42661 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Qingyu Deng <i@ayase-lab.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>

`outgoingMessage.getHeader()`, `outgoingMessage.getHeaderNames()`, and `outgoingMessage.getHeaders()` were added to Node.js v7.7.0 via 3e8d43d165ef. PR-URL: nodejs/node#42661 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Qingyu Deng <i@ayase-lab.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>

nodejs-github-bot added doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem. labels Apr 8, 2022

ShogunPanda approved these changes Apr 8, 2022

View reviewed changes

aduh95 reviewed Apr 8, 2022

View reviewed changes

aduh95 requested changes Apr 8, 2022

View reviewed changes

doc/api/http.md Outdated Show resolved Hide resolved

doc/api/http.md Outdated Show resolved Hide resolved

doc/api/http.md Outdated Show resolved Hide resolved

doc/api/http.md Outdated Show resolved Hide resolved

doc/api/http.md Outdated Show resolved Hide resolved

mcollina approved these changes Apr 9, 2022

View reviewed changes

doc: fix added: info for some methods

723cb67

`outgoingMessage.getHeader()`, `outgoingMessage.getHeaderNames()`, and `outgoingMessage.getHeaders()` were added to Node.js v7.7.0 via 3e8d43d.

lpinca force-pushed the fix/added-info branch from c6767c2 to 723cb67 Compare April 9, 2022 19:00

aduh95 approved these changes Apr 9, 2022

View reviewed changes

aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 9, 2022

mcollina approved these changes Apr 9, 2022

View reviewed changes

Mesteery approved these changes Apr 10, 2022

View reviewed changes

RaisinTen approved these changes Apr 10, 2022

View reviewed changes

Ayase-252 approved these changes Apr 10, 2022

View reviewed changes

marsonya approved these changes Apr 10, 2022

View reviewed changes

lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 11, 2022

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 11, 2022

nodejs-github-bot merged commit 4508c8c into nodejs:master Apr 11, 2022

lpinca deleted the fix/added-info branch April 11, 2022 05:22

BethGriggs mentioned this pull request Apr 11, 2022

2022-04-19, Version 18.0.0 (Current) #42262

Merged

juanarbol mentioned this pull request May 31, 2022

2022-05-XX, Version 16.16.0 'Gallium' (LTS) #43268

Closed

targos mentioned this pull request Aug 3, 2022

v16.17.0 release proposal #44098

Merged

-added:
-  - v8.0.0
-  - v7.7.0
+added: v7.7.0

	## 2015-10-07, Version 4.2.0 'Argon' (LTS), @jasnell

	### Notable changes

	The first Node.js LTS release! See <https://github.com/nodejs/LTS/> for details of the LTS process.

	* icu: Updated to version 56 with significant performance improvements (Steven R. Loomis) [#3281](https://github.com/nodejs/node/pull/3281)
	* node:
	* Added new `-c` (or `--check`) command line argument for checking script syntax without executing the code (Dave Eddy) [#2411](https://github.com/nodejs/node/pull/2411)

Uh oh!

Conversation

lpinca commented Apr 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Apr 8, 2022

Uh oh!

ShogunPanda left a comment

Choose a reason for hiding this comment

Uh oh!

aduh95 Apr 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lpinca Apr 9, 2022

Choose a reason for hiding this comment

Uh oh!

lpinca Apr 9, 2022

Choose a reason for hiding this comment

Uh oh!

lpinca Apr 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lpinca Apr 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aduh95 Apr 9, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Apr 11, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

lpinca commented Apr 8, 2022 •

edited

Loading

aduh95 Apr 8, 2022 •

edited

Loading

lpinca Apr 9, 2022 •

edited

Loading

lpinca Apr 9, 2022 •

edited

Loading