test: add test-domain-exit-dispose-again back by misterdjules · Pull Request #4256 · nodejs/node

misterdjules · 2015-12-12T01:48:54Z

1c85849 "fixed"
test-domain-exit-dispose-again by changing its logic to test that
process.domain was cleared properly in case an error was thrown from a
timer's callback.

However, it became clear when reviewing a recent change that refactors
lib/timers.js that it was not quite the intention of the original test.
Thus, this change adds the original implementation of
test-domain-exit-dispose-again back, with comments that make its
implementation easier to understand.

It also preserve the changes made by
1c85849, but it moves them to a new
test file named test-timers-reset-process-domain-on-throw.js.

/cc @Fishrock123 This is the test I mentioned in #4007 (comment).

1c85849 "fixed" test-domain-exit-dispose-again by changing its logic to test that process.domain was cleared properly in case an error was thrown from a timer's callback. However, it became clear when reviewing a recent change that refactors lib/timers.js that it was not quite the intention of the original test. Thus, this change adds the original implementation of test-domain-exit-dispose-again back, with comments that make its implementation easier to understand. It also preserve the changes made by 1c85849, but it moves them to a new test file named test-timers-reset-process-domain-on-throw.js.

misterdjules · 2015-12-12T01:49:43Z

CI tests running.

Fishrock123 · 2015-12-14T17:53:10Z

Tests seem fine, I'll test it on the PR with and without the related code when I get the chance.

Fishrock123 · 2015-12-14T18:26:42Z

Note: my timers branch does not have 1c85849, and the old version doesn't catch the relevant change in timers.

Fishrock123 · 2015-12-14T18:36:31Z

test/parallel/test-timers-reset-process-domain-on-throw.js

Usually we avoid using process.exit() in tests because it is rather immediate, is there a way this could be switched to Throw?

The problem is explained by the comment above:

// Do not use assert here, as it throws errors and if a domain with an error // handler is active, then asserting wouldn't make the test fail.

maybe this comment should be moved right above the call to process.exit(1)?

Oh, probably. And of course, domains, oopsie.

Sounds good, I'll move it closer to the call to process.exit.

misterdjules · 2015-12-14T18:39:35Z

@Fishrock123 Just to make sure we're on the same page: do you mean that the version of test/parallel/test-domain-exit-dispose-again.js prior to 1c85849 doesn't fail if process.domain is not reset after a timer's callback threw? That's what I'd expect, and I would expect both 1c85849 and the changes in this PR to make that case fail.

misterdjules · 2015-12-17T21:41:24Z

/ping @Fishrock123 Did you have some time to look at my answers to your questions/comments?

misterdjules · 2015-12-21T22:59:44Z

@Fishrock123 Pushed a new commit that I believe addresses your review comments. If that looks good to you, I'll squash the two commits in one. Thanks!

Fishrock123 · 2016-01-04T21:53:45Z

@Fishrock123 Just to make sure we're on the same page: do you mean that the version of test/parallel/test-domain-exit-dispose-again.js prior to 1c85849 doesn't fail if process.domain is not reset after a timer's callback threw? That's what I'd expect, and I would expect both 1c85849 and the changes in this PR to make that case fail.

I don't understand the details, but ok!

Rubber-stamp LGTM as I don't feel like I can adequately assess the tests' details, but since this is just re-introducing an old test it should be fine.

CI again, for good measure: https://ci.nodejs.org/job/node-test-pull-request/1144/

1c85849 "fixed" test-domain-exit-dispose-again by changing its logic to test that process.domain was cleared properly in case an error was thrown from a timer's callback. However, it became clear when reviewing a recent change that refactors lib/timers.js that it was not quite the intention of the original test. Thus, this change adds the original implementation of test-domain-exit-dispose-again back, with comments that make its implementation easier to understand. It also preserve the changes made by 1c85849, but it moves them to a new test file named test-timers-reset-process-domain-on-throw.js. PR: #4256 PR-URL: #4256 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

misterdjules · 2016-01-05T00:43:21Z

Thank you @Fishrock123. Landed in 1453b87.

1c85849 "fixed" test-domain-exit-dispose-again by changing its logic to test that process.domain was cleared properly in case an error was thrown from a timer's callback. However, it became clear when reviewing a recent change that refactors lib/timers.js that it was not quite the intention of the original test. Thus, this change adds the original implementation of test-domain-exit-dispose-again back, with comments that make its implementation easier to understand. It also preserve the changes made by 1c85849, but it moves them to a new test file named test-timers-reset-process-domain-on-throw.js. PR: nodejs#4256 PR-URL: nodejs#4256 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

1c85849 "fixed" test-domain-exit-dispose-again by changing its logic to test that process.domain was cleared properly in case an error was thrown from a timer's callback. However, it became clear when reviewing a recent change that refactors lib/timers.js that it was not quite the intention of the original test. Thus, this change adds the original implementation of test-domain-exit-dispose-again back, with comments that make its implementation easier to understand. It also preserve the changes made by 1c85849, but it moves them to a new test file named test-timers-reset-process-domain-on-throw.js. PR: #4256 PR-URL: #4256 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

1c85849 "fixed" test-domain-exit-dispose-again by changing its logic to test that process.domain was cleared properly in case an error was thrown from a timer's callback. However, it became clear when reviewing a recent change that refactors lib/timers.js that it was not quite the intention of the original test. Thus, this change adds the original implementation of test-domain-exit-dispose-again back, with comments that make its implementation easier to understand. It also preserve the changes made by 1c85849, but it moves them to a new test file named test-timers-reset-process-domain-on-throw.js. PR: nodejs#4256 PR-URL: nodejs#4256 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

Rename the test appropriately alongside mentioning the subsystem Also, make a few basic changes to make sure the test conforms to the standard test structure Refs: nodejs#19105 Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure

Rename the tests appropriately alongside mentioning the subsystem. Also, make a few basic changes to make sure the test conforms to the standard test structure. This renames: - test-regress-nodejsGH-1531 - test-regress-nodejsGH-2245 - test-regress-nodejsGH-3238 - test-regress-nodejsGH-3542 - test-regress-nodejsGH-3739 - test-regress-nodejsGH-4256 PR-URL: nodejs#19212 Refs: nodejs#19105 Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>

Rename the tests appropriately alongside mentioning the subsystem. Also, make a few basic changes to make sure the test conforms to the standard test structure. This renames: - test-regress-GH-1531 - test-regress-GH-2245 - test-regress-GH-3238 - test-regress-GH-3542 - test-regress-GH-3739 - test-regress-GH-4256 PR-URL: #19212 Refs: #19105 Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>

Rename the tests appropriately alongside mentioning the subsystem. Also, make a few basic changes to make sure the test conforms to the standard test structure. This renames: - test-regress-nodejsGH-1531 - test-regress-nodejsGH-2245 - test-regress-nodejsGH-3238 - test-regress-nodejsGH-3542 - test-regress-nodejsGH-3739 - test-regress-nodejsGH-4256 PR-URL: nodejs#19212 Refs: nodejs#19105 Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>

Rename the tests appropriately alongside mentioning the subsystem. Also, make a few basic changes to make sure the test conforms to the standard test structure. This renames: - test-regress-GH-1531 - test-regress-GH-2245 - test-regress-GH-3238 - test-regress-GH-3542 - test-regress-GH-3739 - test-regress-GH-4256 PR-URL: #19212 Refs: #19105 Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>

misterdjules added domain Issues and PRs related to the domain subsystem. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. test Issues and PRs related to the tests. lts-watch-v4.x labels Dec 12, 2015

misterdjules mentioned this pull request Dec 12, 2015

Refactor Timers #4007

Closed

Fishrock123 reviewed Dec 14, 2015
View reviewed changes

misterdjules mentioned this pull request Dec 14, 2015

test: add test-domain-exit-dispose-again back #4278

Closed

Changes according to code review

7bf1f08

Trott force-pushed the master branch from 1e896a6 to 082cc8d Compare December 27, 2015 02:01

misterdjules closed this Jan 5, 2016

MylesBorins added land-on-v4.x and removed land-on-v5.x labels Jan 13, 2016

MylesBorins mentioned this pull request Jan 19, 2016

V4.2.5 proposal #4768

Merged

misterdjules deleted the readd-test-domain-exit-dispose-again branch July 24, 2017 17:35

This was referenced Mar 6, 2018

test: rename regression tests with descriptive file names #19161

Closed

test: rename regression tests with descriptive file names #19212

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

test: add test-domain-exit-dispose-again back#4256

test: add test-domain-exit-dispose-again back#4256
misterdjules wants to merge 2 commits intonodejs:masterfrom
misterdjules:readd-test-domain-exit-dispose-again

misterdjules commented Dec 12, 2015

Uh oh!

misterdjules commented Dec 12, 2015

Uh oh!

Fishrock123 commented Dec 14, 2015

Uh oh!

Fishrock123 commented Dec 14, 2015

Uh oh!

Fishrock123 Dec 14, 2015

Uh oh!

misterdjules Dec 14, 2015

Uh oh!

Fishrock123 Dec 21, 2015

Uh oh!

misterdjules Dec 21, 2015

Uh oh!

misterdjules commented Dec 14, 2015

Uh oh!

misterdjules commented Dec 17, 2015

Uh oh!

misterdjules commented Dec 21, 2015

Uh oh!

Fishrock123 commented Jan 4, 2016

Uh oh!

misterdjules commented Jan 5, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

misterdjules commented Dec 12, 2015

Uh oh!

misterdjules commented Dec 12, 2015

Uh oh!

Fishrock123 commented Dec 14, 2015

Uh oh!

Fishrock123 commented Dec 14, 2015

Uh oh!

Fishrock123 Dec 14, 2015

Choose a reason for hiding this comment

Uh oh!

misterdjules Dec 14, 2015

Choose a reason for hiding this comment

Uh oh!

Fishrock123 Dec 21, 2015

Choose a reason for hiding this comment

Uh oh!

misterdjules Dec 21, 2015

Choose a reason for hiding this comment

Uh oh!

misterdjules commented Dec 14, 2015

Uh oh!

misterdjules commented Dec 17, 2015

Uh oh!

misterdjules commented Dec 21, 2015

Uh oh!

Fishrock123 commented Jan 4, 2016

Uh oh!

misterdjules commented Jan 5, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants