doc: clarify recommendations in stream.md#42555
Merged
Trott merged 1 commit intonodejs:masterfrom Apr 3, 2022
Merged
Conversation
nodejs-github-bot
added
doc
Mesteery
approved these changes
Apr 1, 2022
bnb
approved these changes
Apr 1, 2022
benjamingr
reviewed
Apr 1, 2022
| implemented to provide the easiest way of consuming stream data. Developers that | ||
| require more fine-grained control over the transfer and generation of data can | ||
| use the [`EventEmitter`][] and `readable.on('readable')`/`readable.read()` | ||
| `readable.pipe()` provides the easiest way to consume stream data. Developers |
Member
There was a problem hiding this comment.
This statement has not been true for years (at least since we had async/iterators support).
I would remove these 3 lines altogether or maybe replace them with:
readable.pipe is a low-level API to connect streams. It is preferred to use [pipeline][] or [compose][] to connect streams. For convenience you can iterate streams with for... await loops or .toArray() a stream which is convenient but not as performant.
Or a better phrasing of that
benjamingr
approved these changes
Apr 1, 2022
marsonya
approved these changes
Apr 1, 2022
Trott
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/42555
FetchError: Invalid response body while trying to fetch https://api.github.com/graphql: Premature close
at consumeBody (file:///opt/hostedtoolcache/node/16.14.0/x64/lib/node_modules/node-core-utils/node_modules/node-fetch/src/body.js:234:60)
at processTicksAndRejections (node:internal/process/task_queues:96:5)
at async Response.text (file:///opt/hostedtoolcache/node/16.14.0/x64/lib/node_modules/node-core-utils/node_modules/node-fetch/src/body.js:158:18)
at async Request.json (file:///opt/hostedtoolcache/node/16.14.0/x64/lib/node_modules/node-core-utils/lib/request.js:49:18)
at async Request.query (file:///opt/hostedtoolcache/node/16.14.0/x64/lib/node_modules/node-core-utils/lib/request.js:107:20)
at async Request.queryAll (file:///opt/hostedtoolcache/node/16.14.0/x64/lib/node_modules/node-core-utils/lib/request.js:134:20)
at async Request.gql (file:///opt/hostedtoolcache/node/16.14.0/x64/lib/node_modules/node-core-utils/lib/request.js:64:22)
at async PRData.getComments (file:///opt/hostedtoolcache/node/16.14.0/x64/lib/node_modules/node-core-utils/lib/pr_data.js:97:21)
at async Promise.all (index 2)
at async Promise.all (index 1) {
type: 'system',
errno: 'ERR_STREAM_PREMATURE_CLOSE',
code: 'ERR_STREAM_PREMATURE_CLOSE',
erroredSysCall: undefined
}https://github.com/nodejs/node/actions/runs/2084348110 |
nodejs-github-bot
added
the
commit-queue-failed
PR-URL: nodejs#42555 Reviewed-By: Mestery <[email protected]> Reviewed-By: Tierney Cyren <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Akhil Marsonya <[email protected]>
Member
Author
|
Landed in b717795 |
juanarbol
pushed a commit
to juanarbol/node
that referenced
this pull request
Apr 5, 2022
PR-URL: nodejs#42555 Reviewed-By: Mestery <[email protected]> Reviewed-By: Tierney Cyren <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Akhil Marsonya <[email protected]>
juanarbol
pushed a commit
that referenced
this pull request
Apr 6, 2022
PR-URL: #42555 Reviewed-By: Mestery <[email protected]> Reviewed-By: Tierney Cyren <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Akhil Marsonya <[email protected]>
xtx1130
pushed a commit
to xtx1130/node
that referenced
this pull request
Apr 25, 2022
PR-URL: nodejs#42555 Reviewed-By: Mestery <[email protected]> Reviewed-By: Tierney Cyren <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Akhil Marsonya <[email protected]>
juanarbol
pushed a commit
that referenced
this pull request
May 31, 2022
PR-URL: #42555 Reviewed-By: Mestery <[email protected]> Reviewed-By: Tierney Cyren <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Akhil Marsonya <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jun 27, 2022
PR-URL: #42555 Reviewed-By: Mestery <[email protected]> Reviewed-By: Tierney Cyren <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Akhil Marsonya <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jul 11, 2022
PR-URL: #42555 Reviewed-By: Mestery <[email protected]> Reviewed-By: Tierney Cyren <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Akhil Marsonya <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
PR-URL: #42555 Reviewed-By: Mestery <[email protected]> Reviewed-By: Tierney Cyren <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Akhil Marsonya <[email protected]>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
PR-URL: nodejs/node#42555 Reviewed-By: Mestery <[email protected]> Reviewed-By: Tierney Cyren <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Akhil Marsonya <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.