doc: remove extraneous comma#42548
Merged
nodejs-github-bot merged 1 commit intonodejs:masterfrom Apr 1, 2022
Merged
Conversation
Contributor
|
Fast-track has been requested by @Trott. Please 👍 to approve. |
nodejs-github-bot
added
cluster
richardlau
approved these changes
Mar 31, 2022
tniessen
approved these changes
Mar 31, 2022
| on a unique port, generate a port number based on the cluster worker ID. | ||
|
|
||
| Node.js does not provide routing logic. It is, therefore important to design an | ||
| Node.js does not provide routing logic. It is therefore important to design an |
Member
There was a problem hiding this comment.
Suggested change
| Node.js does not provide routing logic. It is therefore important to design an | |
| Node.js does not provide routing logic. It is, therefore, important to design an |
Member
Author
There was a problem hiding this comment.
That would work too but I think it's better without the commas. I will do it that way if you have a strong preference though. As long as there are either two commas or zero commas, I'm good. One comma is Not OK.
Contributor
There was a problem hiding this comment.
is therefore even necessary language here? Feels like a flourish that can potentially be just dropped.
Member
Author
There was a problem hiding this comment.
Honestly, I was just looking for the smallest possible change to fix the issue in the text, so adding a comma or removing a comma were the options I considered. The word therefore is perhaps not necessary, but I think it is valuable as a cue that the recommendation in this sentence is due to the condition explained in the previous sentence. That said, I'm OK with removing it if that's the consensus.
Member
Author
There was a problem hiding this comment.
But uh...I see this has sufficient approvals as is, so I'm going to land before we bikeshed any further. 😀
Mesteery
approved these changes
Apr 1, 2022
Trott
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in fd18b0e |
juanarbol
pushed a commit
to juanarbol/node
that referenced
this pull request
Apr 5, 2022
PR-URL: nodejs#42548 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Mestery <mestery@protonmail.com>
juanarbol
pushed a commit
that referenced
this pull request
Apr 6, 2022
PR-URL: #42548 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Mestery <mestery@protonmail.com>
xtx1130
pushed a commit
to xtx1130/node
that referenced
this pull request
Apr 25, 2022
PR-URL: nodejs#42548 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Mestery <mestery@protonmail.com>
juanarbol
pushed a commit
that referenced
this pull request
May 31, 2022
PR-URL: #42548 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Mestery <mestery@protonmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jun 27, 2022
PR-URL: #42548 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Mestery <mestery@protonmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 11, 2022
PR-URL: #42548 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Mestery <mestery@protonmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 11, 2022
PR-URL: #42548 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Mestery <mestery@protonmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
PR-URL: #42548 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Mestery <mestery@protonmail.com>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
PR-URL: nodejs/node#42548 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Mestery <mestery@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.