stream: revert map spec compliance by benjamingr · Pull Request #41931 · nodejs/node

benjamingr · 2022-02-11T10:12:23Z

cc @ronag @mcollina

fixes: #41926

Is there a way to ask this doesn't land on 18 but only 17 and below?

(If it's an issue I'll just make a follow up revert PR tagged with the appropriate "don't land on" tags)

nodejs-github-bot · 2022-02-11T10:12:27Z

Review requested:

@nodejs/streams

aduh95 · 2022-02-11T10:16:35Z

Is there a way to ask this doesn't land on 18 but only 17 and below?

Once this lands, you can open a revert and label it as semver-major PRs that contain breaking changes and should be released in the next major version. .

nodejs-github-bot · 2022-02-11T10:24:09Z

CI: https://ci.nodejs.org/job/node-test-pull-request/42477/

mcollina

lgtm

mcollina · 2022-02-11T10:29:06Z

Please tag the revert as notable-change so that people will know that a breaking change landed

mcollina · 2022-02-11T10:58:10Z

Fast track?

github-actions · 2022-02-11T11:01:31Z

Fast-track has been requested by @mcollina. Please 👍 to approve.

nodejs-github-bot · 2022-02-11T11:54:47Z

CI: https://ci.nodejs.org/job/node-test-pull-request/42485/

aduh95 · 2022-02-11T13:11:26Z

Landed in 91d28d8

PR-URL: nodejs#41931 Fixes: nodejs#41926 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com>

Notable changes: * [bdbe655] - doc: add marsonya to collaborators (Akhil Marsonya) nodejs#41991 * [8fe8dee] - doc: deprecate notice for process methods (Yash Ladha) nodejs#41587 * [abd6967] - stream: revert `map` spec compliance (Benjamin Gruenbaum) nodejs#41931 * [b968d89] - build: remove broken x32 arch support (Ben Noordhuis) nodejs#41905 * [ba639d0] - (SEMVER-MINOR) esm: support https remotely and http locally under flag (Bradley Farias) nodejs#36328 * [0de611f] - doc: add joesepi to collaborators (Joe Sepi) nodejs#41914 * [5796c3a] - process: deprecate multipleResolves (Benjamin Gruenbaum) nodejs#41872

PR-URL: nodejs#41931 Fixes: nodejs#41926 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com>

Notable changes: * [d1bac7f] - doc: add marsonya to collaborators (Akhil Marsonya) nodejs#41991 * [a69ddde] - doc: deprecate notice for process methods (Yash Ladha) nodejs#41587 * [a89a853] - stream: revert `map` spec compliance (Benjamin Gruenbaum) nodejs#41931 * [d138355] - build: remove broken x32 arch support (Ben Noordhuis) nodejs#41905 * [fd3dabf] - doc: add joesepi to collaborators (Joe Sepi) nodejs#41914 * [a84c29c] - process: deprecate multipleResolves (Benjamin Gruenbaum) nodejs#41872

Notable changes: * [bdbe655] - doc: add marsonya to collaborators (Akhil Marsonya) #41991 * [8fe8dee] - doc: deprecate notice for process methods (Yash Ladha) #41587 * [abd6967] - stream: revert `map` spec compliance (Benjamin Gruenbaum) #41931 * [b968d89] - build: remove broken x32 arch support (Ben Noordhuis) #41905 * [ba639d0] - (SEMVER-MINOR) esm: support https remotely and http locally under flag (Bradley Farias) #36328 * [0de611f] - doc: add joesepi to collaborators (Joe Sepi) #41914 * [5796c3a] - process: deprecate multipleResolves (Benjamin Gruenbaum) #41872

Notable changes: * [bdbe655] - doc: add marsonya to collaborators (Akhil Marsonya) #41991 * [8fe8dee] - doc: deprecate notice for process methods (Yash Ladha) #41587 * [abd6967] - stream: revert `map` spec compliance (Benjamin Gruenbaum) #41931 * [b968d89] - build: remove broken x32 arch support (Ben Noordhuis) #41905 * [ba639d0] - (SEMVER-MINOR) esm: support https remotely and http locally under flag (Bradley Farias) #36328 * [0de611f] - doc: add joesepi to collaborators (Joe Sepi) #41914 * [5796c3a] - process: deprecate multipleResolves (Benjamin Gruenbaum) #41872 PR-URL: #42072

* 326f545 - doc: deprecate notice for process methods (Yash Ladha) #41587 * abd6967 - stream: revert `map` spec compliance (Benjamin Gruenbaum) #41931 * b968d89 - build: remove broken x32 arch support (Ben Noordhuis) [#41905](#41905) * 88cbceb - (SEMVER-MINOR) crypto: expose Web Crypto API on the global scope (Antoine du Hamel) [#41938](#41938) * ba639d0 - (SEMVER-MINOR) esm: support https remotely and http locally under flag (Bradley Farias) [#36328](#36328) * 1e862b3 - (SEMVER-MINOR) fs: support copy of relative links with cp and cpSync (Marcos Bjoerkelund) [#41819](#41819) * 4fbe064 - (SEMVER-MINOR) lib: add FormData global when fetch is enabled (Michaël Zasso) [#41956](#41956) * 3243701 - (SEMVER-MINOR) readline: bind keystroke `ctrl`+`6` to redo (Ray) [#41662](#41662) * 5796c3a - process: deprecate multipleResolves (Benjamin Gruenbaum) [#41872](#41872) * Documentation-only. * \[[`811f04bd34`](811f04bd34)] - **deps**: upgrade npm to 8.5.1 (npm-robot) [#42039](#42039) * \[[`605271ba8c`](605271ba8c)] - **deps**: update undici to 3e267ece5f (Michaël Zasso) [#41955](#41955) * \[[`0a6f0b416f`](0a6f0b416f)] - **deps**: upgrade npm to 8.5.0 (npm-robot) [#41925](#41925) * \[[`7c19c7496e`](7c19c7496e)] - **doc**: add marsonya to collaborators (Akhil Marsonya) [#41991](#41991) * \[[`0de611f53a`](0de611f53a)] - **doc**: add joesepi to collaborators (Joe Sepi) [#41914](#41914) PR-URL: #42072

Notable changes: - doc: deprecate notice for process methods (Yash Ladha) #41587 - stream: revert `map` spec compliance (Benjamin Gruenbaum) #41931 - build: remove broken x32 arch support (Ben Noordhuis) #41905 - (SEMVER-MINOR) crypto: expose Web Crypto API on the global scope (Antoine du Hamel) #41938 - (SEMVER-MINOR) esm: support https remotely and http locally under flag (Bradley Farias) #36328 - (SEMVER-MINOR) fs: support copy of relative links with cp and cpSync (Marcos Bjoerkelund) #41819 - (SEMVER-MINOR) lib: add FormData global when fetch is enabled (Michaël Zasso) #41956 - (SEMVER-MINOR) readline: bind keystroke `ctrl`+`6` to redo (Ray) #41662 - process: deprecate multipleResolves (Benjamin Gruenbaum) #41872 - Documentation-only. Dependency updates: - deps: upgrade npm to 8.5.1 (npm-robot) #42039 - deps: update undici to 3e267ece5f (Michaël Zasso) #41955 - deps: upgrade npm to 8.5.0 (npm-robot) #41925 New collaborators: - doc: add marsonya to collaborators (Akhil Marsonya) #41991 - doc: add joesepi to collaborators (Joe Sepi) #41914 PR-URL: #42072

Notable changes: - doc: deprecate notice for process methods (Yash Ladha) #41587 - stream: revert `map` spec compliance (Benjamin Gruenbaum) #41931 - build: remove broken x32 arch support (Ben Noordhuis) #41905 - (SEMVER-MINOR) esm: support https remotely and http locally under flag (Bradley Farias) #36328 - (SEMVER-MINOR) fs: support copy of relative links with cp and cpSync (Marcos Bjoerkelund) #41819 - (SEMVER-MINOR) lib: add FormData global when fetch is enabled (Michaël Zasso) #41956 - (SEMVER-MINOR) readline: bind keystroke `ctrl`+`6` to redo (Ray) #41662 - process: deprecate multipleResolves (Benjamin Gruenbaum) #41872 - Documentation-only. Dependency updates: - deps: upgrade npm to 8.5.1 (npm-robot) #42039 - deps: update undici to 3e267ece5f (Michaël Zasso) #41955 - deps: upgrade npm to 8.5.0 (npm-robot) #41925 New collaborators: - doc: add marsonya to collaborators (Akhil Marsonya) #41991 - doc: add joesepi to collaborators (Joe Sepi) #41914 PR-URL: #42072

PR-URL: #41931 Fixes: #41926 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com>

Notable changes: - doc: deprecate notice for process methods (Yash Ladha) #41587 - stream: revert `map` spec compliance (Benjamin Gruenbaum) #41931 - build: remove broken x32 arch support (Ben Noordhuis) #41905 - (SEMVER-MINOR) esm: support https remotely and http locally under flag (Bradley Farias) #36328 - (SEMVER-MINOR) fs: support copy of relative links with cp and cpSync (Marcos Bjoerkelund) #41819 - (SEMVER-MINOR) lib: add FormData global when fetch is enabled (Michaël Zasso) #41956 - (SEMVER-MINOR) readline: bind keystroke `ctrl`+`6` to redo (Ray) #41662 - process: deprecate multipleResolves (Benjamin Gruenbaum) #41872 - Documentation-only. Dependency updates: - deps: upgrade npm to 8.5.1 (npm-robot) #42039 - deps: update undici to 3e267ece5f (Michaël Zasso) #41955 - deps: upgrade npm to 8.5.0 (npm-robot) #41925 New collaborators: - doc: add marsonya to collaborators (Akhil Marsonya) #41991 - doc: add joesepi to collaborators (Joe Sepi) #41914 PR-URL: #42072

danielleadams · 2022-04-20T00:36:01Z

@benjamingr this breaks tests on v16.x when landing. Do you mind opening a backport PR?

stream: revert map spec compliance

37c6e0e

nodejs-github-bot added needs-ci PRs that need a full CI run. stream Issues and PRs related to the stream subsystem. labels Feb 11, 2022

aduh95 approved these changes Feb 11, 2022

View reviewed changes

benjamingr added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 11, 2022

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 11, 2022

mcollina approved these changes Feb 11, 2022

View reviewed changes

benjamingr added the notable-change PRs with changes that should be highlighted in changelogs. label Feb 11, 2022

ronag approved these changes Feb 11, 2022

View reviewed changes

aduh95 added the fast-track PRs that do not need to wait for 48 hours to land. label Feb 11, 2022

aduh95 merged commit 91d28d8 into nodejs:master Feb 11, 2022

benjamingr mentioned this pull request Feb 11, 2022

stream: revert revert map spec compliance #41933

Merged

This was referenced Feb 12, 2022

CI Reliability 2022-02-12 nodejs/reliability#200

Open

CI Reliability 2022-02-13 nodejs/reliability#201

Open

CI Reliability 2022-02-14 nodejs/reliability#202

Open

CI Reliability 2022-02-15 nodejs/reliability#203

Open

bengl mentioned this pull request Feb 21, 2022

v17.6.0 release proposal #42072

Merged

azu mentioned this pull request Mar 1, 2022

2022-03-01のJS: Redux Toolkit 1.8.0、Node.js 17.6.0、CSS Cascade Layers jser/jser.github.io#964

Merged

danielleadams added the backport-requested-v16.x label Apr 20, 2022

targos added dont-land-on-v16.x and removed backport-requested-v16.x labels Jul 31, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

stream: revert map spec compliance#41931

stream: revert map spec compliance#41931
aduh95 merged 1 commit intonodejs:masterfrom
benjamingr:issue-41926

benjamingr commented Feb 11, 2022

Uh oh!

nodejs-github-bot commented Feb 11, 2022

Uh oh!

aduh95 commented Feb 11, 2022

Uh oh!

nodejs-github-bot commented Feb 11, 2022

Uh oh!

mcollina left a comment

Uh oh!

mcollina commented Feb 11, 2022

Uh oh!

mcollina commented Feb 11, 2022

Uh oh!

github-actions bot commented Feb 11, 2022 •

edited by aduh95

Loading

Uh oh!

nodejs-github-bot commented Feb 11, 2022

Uh oh!

aduh95 commented Feb 11, 2022

Uh oh!

danielleadams commented Apr 20, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Uh oh!

Conversation

benjamingr commented Feb 11, 2022

Uh oh!

nodejs-github-bot commented Feb 11, 2022

Uh oh!

aduh95 commented Feb 11, 2022

Uh oh!

nodejs-github-bot commented Feb 11, 2022

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

mcollina commented Feb 11, 2022

Uh oh!

mcollina commented Feb 11, 2022

Uh oh!

github-actions bot commented Feb 11, 2022 • edited by aduh95 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Feb 11, 2022

Uh oh!

aduh95 commented Feb 11, 2022

Uh oh!

danielleadams commented Apr 20, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

github-actions bot commented Feb 11, 2022 •

edited by aduh95

Loading