doc: improve wording surrounding TLS 1.3 ciphers#41778
Merged
nodejs-github-bot merged 1 commit intonodejs:masterfrom Feb 1, 2022
Merged
Conversation
Spelling out numbers makes this part easier to read. Also remove the unnecessary word 'last'.
nodejs-github-bot
added
doc
Contributor
|
Maybe we should just split the list up to make it even easier to digest? |
Trott
reviewed
Jan 31, 2022
Trott
reviewed
Jan 31, 2022
Comment on lines
357
to
358
| [TLS recommendations][] may offer a compatible cipher suite. For more details | ||
| on the format, see the OpenSSL [cipher list format][] documentation. |
Member
There was a problem hiding this comment.
Not related to this PR necessarily, but this paragraph apparently is for people who need compatibility with clients like IE6. I wonder if we can/should remove it.
Trott
approved these changes
Jan 31, 2022
Member
Trott
left a comment
Trott
left a comment
There was a problem hiding this comment.
LGTM with or without my comments addressed.
Mesteery
approved these changes
Jan 31, 2022
benjamingr
approved these changes
Jan 31, 2022
Linkgoron
approved these changes
Jan 31, 2022
lpinca
approved these changes
Jan 31, 2022
cjihrig
approved these changes
Feb 1, 2022
tniessen
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in dcf4890 |
ruyadorno
pushed a commit
that referenced
this pull request
Feb 8, 2022
Spelling out numbers makes this part easier to read. Also remove the unnecessary word 'last'. PR-URL: #41778 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Nitzan Uziely <linkgoron@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Mar 2, 2022
Spelling out numbers makes this part easier to read. Also remove the unnecessary word 'last'. PR-URL: #41778 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Nitzan Uziely <linkgoron@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Mar 3, 2022
Spelling out numbers makes this part easier to read. Also remove the unnecessary word 'last'. PR-URL: #41778 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Nitzan Uziely <linkgoron@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Mar 14, 2022
Spelling out numbers makes this part easier to read. Also remove the unnecessary word 'last'. PR-URL: #41778 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Nitzan Uziely <linkgoron@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spelling out numbers makes this part easier to read. Also remove the unnecessary word 'last'.
(This is also recommended by the style guide we follow: https://docs.microsoft.com/en-us/style-guide/numbers)