test: fix typo in MessageChannel test#41746
Merged
aduh95 merged 1 commit intonodejs:masterfrom Jan 29, 2022
Merged
Conversation
Contributor
|
Fast-track has been requested by @tniessen. Please 👍 to approve. |
nodejs-github-bot
added
needs-ci
targos
approved these changes
Jan 29, 2022
Mesteery
approved these changes
Jan 29, 2022
aduh95
approved these changes
Jan 29, 2022
aduh95
added
author ready
Contributor
|
Changes that only affect a comment do not affect the node/doc/contributing/collaborator-guide.md Lines 208 to 210 in a199387 |
benjamingr
approved these changes
Jan 29, 2022
benjamingr
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/41746 ✔ Done loading data for nodejs/node/pull/41746 ----------------------------------- PR info ------------------------------------ Title test: fix typo in MessageChannel test (#41746) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch tniessen:test-typo-msgchannel -> nodejs:master Labels test, fast-track, author ready Commits 1 - test: fix typo in MessageChannel test Committers 1 - GitHub PR-URL: https://github.com/nodejs/node/pull/41746 Reviewed-By: Michaël Zasso Reviewed-By: Mestery Reviewed-By: Antoine du Hamel Reviewed-By: Benjamin Gruenbaum ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/41746 Reviewed-By: Michaël Zasso Reviewed-By: Mestery Reviewed-By: Antoine du Hamel Reviewed-By: Benjamin Gruenbaum -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 29 Jan 2022 12:22:00 GMT ✔ Approvals: 4 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/41746#pullrequestreview-866955342 ✔ - Mestery (@Mesteery): https://github.com/nodejs/node/pull/41746#pullrequestreview-866955586 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/41746#pullrequestreview-866955713 ✔ - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/41746#pullrequestreview-866963791 ℹ This PR is being fast-tracked ✖ GitHub CI is still running ✖ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1765967304 |
nodejs-github-bot
added
the
commit-queue-failed
Member
|
Ah apparently commit queue doesn’t work for changes that don’t require Jenkins CI? |
RaisinTen
approved these changes
Jan 29, 2022
tniessen
removed
the
commit-queue-failed
Member
Author
I believe it should, but this PR was marked as |
Contributor
|
Landed in 74de555.
Yes, it's unfortunate but the CQ was built to be extra cautious and is not actually able to differentiate a change in a comment than a change in the code. Landing manually is required there. |
Linkgoron
pushed a commit
to Linkgoron/node
that referenced
this pull request
Jan 31, 2022
PR-URL: nodejs#41746 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
ruyadorno
pushed a commit
that referenced
this pull request
Feb 8, 2022
PR-URL: #41746 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Mar 2, 2022
PR-URL: #41746 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Mar 3, 2022
PR-URL: #41746 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Mar 14, 2022
PR-URL: #41746 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.