Skip to content

tools: use Set instead of { [key]: true } object#41695

Merged
nodejs-github-bot merged 1 commit intonodejs:masterfrom
tniessen:tools-doc-alljson-seen-should-be-set
Jan 28, 2022
Merged

tools: use Set instead of { [key]: true } object#41695
nodejs-github-bot merged 1 commit intonodejs:masterfrom
tniessen:tools-doc-alljson-seen-should-be-set

Conversation

@tniessen
Copy link
Member

@tniessen tniessen commented Jan 25, 2022

I forgot about alljson.mjs in #41675...

@tniessen tniessen added the fast-track PRs that do not need to wait for 48 hours to land. label Jan 25, 2022
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory. labels Jan 25, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jan 25, 2022

Fast-track has been requested by @tniessen. Please 👍 to approve.

@tniessen tniessen changed the title tools: use Set instead of { [key]: true } object tools: use Set instead of { [key]: true } object Jan 26, 2022
@tniessen tniessen added commit-queue Add this label to land a pull request using GitHub Actions. and removed fast-track PRs that do not need to wait for 48 hours to land. labels Jan 28, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 28, 2022
@nodejs-github-bot nodejs-github-bot merged commit 334fb38 into nodejs:master Jan 28, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 28, 2022

Landed in 334fb38

Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
@tniessen @Linkgoron
tools: use Set instead of { [key]: true } object
be9b554 
Refs: nodejs#41675

PR-URL: nodejs#41695
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
ruyadorno pushed a commit that referenced this pull request Feb 8, 2022
@tniessen @ruyadorno
tools: use Set instead of { [key]: true } object
3190e36 
Refs: #41675

PR-URL: #41695
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Feb 8, 2022
Merged
danielleadams pushed a commit that referenced this pull request Mar 2, 2022
@tniessen @danielleadams
tools: use Set instead of { [key]: true } object
799f850 
Refs: #41675

PR-URL: #41695
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@danielleadams danielleadams mentioned this pull request Mar 3, 2022
Merged
danielleadams pushed a commit that referenced this pull request Mar 3, 2022
@tniessen @danielleadams
tools: use Set instead of { [key]: true } object
3918467 
Refs: #41675

PR-URL: #41695
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
@tniessen @danielleadams
tools: use Set instead of { [key]: true } object
9d23a27 
Refs: #41675

PR-URL: #41695
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

+1 more reviewer

@Mesteery Mesteery Mesteery approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@tniessen @nodejs-github-bot @lpinca @cjihrig @Mesteery @VoltrexKeyva