doc: update Mesteery email#41683
Merged
nodejs-github-bot merged 2 commits intonodejs:masterfrom Jan 29, 2022
Merged
Conversation
aduh95
reviewed
Jan 24, 2022
aduh95
approved these changes
Jan 24, 2022
Trott
reviewed
Jan 24, 2022
| **Akhil Marsonya** <<[email protected]>> (he/him) | ||
| * [Mesteery](https://github.com/Mesteery) - | ||
| **Mestery** <<mestery@pm.me>> | ||
| **Mestery** <<mestery@protonmail.com>> (he/him) |
Member
There was a problem hiding this comment.
Can you add a .mailmap entry for this too so that your entry here matches your entry in AUTHORS and so that you won't show up in AUTHORS twice?
It should look something like this and be placed in the right place in .mailmap alphabetically:
Mestery <[email protected]> <[email protected]>
After you add the entry, you can test it by running tools/update-authors.js. That will update the AUTHORS file and automatically change your pm.me entry to protonmail.com. Then add that version of AUTHORS to this PR> (It may also add new entries to the end of the AUTHORS file. You can delete those or leave them as part of this PR.)
All told, three files need to be updated: README.md, .mailmap, and (via the update script) AUTHORS.
benjamingr
approved these changes
Jan 24, 2022
lpinca
approved these changes
Jan 26, 2022
jasnell
approved these changes
Jan 28, 2022
benjamingr
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 44f8b4f |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jan 29, 2022
nodejs-github-bot
pushed a commit
that referenced
this pull request
Jan 29, 2022
Refs: #41683 (review) PR-URL: #41751 Reviewed-By: Mestery <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Linkgoron
pushed a commit
to Linkgoron/node
that referenced
this pull request
Jan 31, 2022
PR-URL: nodejs#41683 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Linkgoron
pushed a commit
to Linkgoron/node
that referenced
this pull request
Jan 31, 2022
Refs: nodejs#41683 (review) PR-URL: nodejs#41751 Reviewed-By: Mestery <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
ruyadorno
pushed a commit
that referenced
this pull request
Feb 8, 2022
PR-URL: #41683 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
ruyadorno
pushed a commit
that referenced
this pull request
Feb 8, 2022
Refs: #41683 (review) PR-URL: #41751 Reviewed-By: Mestery <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Mar 2, 2022
PR-URL: #41683 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Mar 2, 2022
Refs: #41683 (review) PR-URL: #41751 Reviewed-By: Mestery <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Mar 3, 2022
PR-URL: #41683 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Mar 3, 2022
Refs: #41683 (review) PR-URL: #41751 Reviewed-By: Mestery <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Mar 14, 2022
PR-URL: #41683 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Mar 14, 2022
Refs: #41683 (review) PR-URL: #41751 Reviewed-By: Mestery <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.