doc: clarify treatment of non-string argument to new URL() by Trott · Pull Request #41658 · nodejs/node

Trott · 2022-01-23T00:21:07Z

doc/api/url.md

Co-authored-by: Timothy Gu <timothygu99@gmail.com>

Trott · 2022-01-23T06:31:56Z

doc/api/url.md

  is relative, then `base` is required. If `input` is absolute, the `base`
-  is ignored.
+  is ignored. If `input` is not a string, it is [converted to a string][] first.
 * `base` {string|URL} The base URL to resolve against if the `input` is not


base is also USVString so perhaps this should be {string} rather than {string|URL} and also include the note about being converted to a string that is added on line 134 for input.

base is also USVString so perhaps this should be {string} rather than {string|URL} and also include the note about being converted to a string that is added on line 134 for input.

@TimothyGu @jasnell Sound OK to you?

nodejs-github-bot · 2022-01-25T01:37:56Z

Commit Queue failed

- Loading data for nodejs/node/pull/41658 ✔ Done loading data for nodejs/node/pull/41658 ----------------------------------- PR info ------------------------------------ Title doc: clarify treatment of non-string argument to new URL() (#41658) Author Rich Trott (@Trott) Branch Trott:newurl -> nodejs:master Labels doc, url, author ready Commits 2 - doc: clarify treatment of non-string argument to new URL() - Update doc/api/url.md Committers 2 - Rich Trott - GitHub PR-URL: https://github.com/nodejs/node/pull/41658 Fixes: https://github.com/nodejs/node/issues/41653 Reviewed-By: Richard Lau Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Luigi Pinca Reviewed-By: Darshan Sen Reviewed-By: Mestery Reviewed-By: Benjamin Gruenbaum ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/41658 Fixes: https://github.com/nodejs/node/issues/41653 Reviewed-By: Richard Lau Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Luigi Pinca Reviewed-By: Darshan Sen Reviewed-By: Mestery Reviewed-By: Benjamin Gruenbaum -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 23 Jan 2022 00:21:07 GMT ✔ Approvals: 6 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/41658#pullrequestreview-860252993 ✔ - Mohammed Keyvanzadeh (@VoltrexMaster): https://github.com/nodejs/node/pull/41658#pullrequestreview-860254672 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/41658#pullrequestreview-860283743 ✔ - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/41658#pullrequestreview-860316074 ✔ - Mestery (@Mesteery): https://github.com/nodejs/node/pull/41658#pullrequestreview-860318289 ✔ - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/41658#pullrequestreview-861643651 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/master up to date... From https://github.com/nodejs/node * branch master -> FETCH_HEAD ✔ origin/master is now up-to-date - Downloading patch for 41658 From https://github.com/nodejs/node * branch refs/pull/41658/merge -> FETCH_HEAD ✔ Fetched commits as b27ae24dcc42..ff5b5a438465 -------------------------------------------------------------------------------- [master fb622bf670] doc: clarify treatment of non-string argument to new URL() Author: Rich Trott Date: Sat Jan 22 16:18:30 2022 -0800 1 file changed, 3 insertions(+), 2 deletions(-) [master 93ce1361e9] Update doc/api/url.md Author: Rich Trott Date: Sat Jan 22 22:30:00 2022 -0800 1 file changed, 1 insertion(+), 1 deletion(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
doc: clarify treatment of non-string argument to new URL()

Closes: #41653

PR-URL: #41658
Fixes: #41653
Reviewed-By: Richard Lau rlau@redhat.com
Reviewed-By: Mohammed Keyvanzadeh mohammadkeyvanzade94@gmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Reviewed-By: Darshan Sen raisinten@gmail.com
Reviewed-By: Mestery mestery@protonmail.com
Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com

[detached HEAD e4abdaf84a] doc: clarify treatment of non-string argument to new URL()
Author: Rich Trott rtrott@gmail.com
Date: Sat Jan 22 16:18:30 2022 -0800
1 file changed, 3 insertions(+), 2 deletions(-)
Rebasing (3/4)
Rebasing (4/4)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
Update doc/api/url.md

Co-authored-by: Timothy Gu timothygu99@gmail.com

PR-URL: #41658
Fixes: #41653
Reviewed-By: Richard Lau rlau@redhat.com
Reviewed-By: Mohammed Keyvanzadeh mohammadkeyvanzade94@gmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Reviewed-By: Darshan Sen raisinten@gmail.com
Reviewed-By: Mestery mestery@protonmail.com
Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com

[detached HEAD 4d0563e1a8] Update doc/api/url.md
Author: Rich Trott rtrott@gmail.com
Date: Sat Jan 22 22:30:00 2022 -0800
1 file changed, 1 insertion(+), 1 deletion(-)

Successfully rebased and updated refs/heads/master.

ℹ Use --fixupAll option, squash the PR manually or land the PR from the command line.

https://github.com/nodejs/node/actions/runs/1743119502

nodejs-github-bot · 2022-01-25T02:04:24Z

Landed in 88a3bd5

Closes: nodejs#41653 PR-URL: nodejs#41658 Fixes: nodejs#41653 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

Closes: #41653 PR-URL: #41658 Fixes: #41653 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

doc: clarify treatment of non-string argument to new URL()

bba1f4d

Closes: nodejs#41653

nodejs-github-bot added doc Issues and PRs related to the documentations. url Issues and PRs related to the legacy built-in url module. labels Jan 23, 2022

richardlau approved these changes Jan 23, 2022

View reviewed changes

Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 23, 2022

VoltrexKeyva approved these changes Jan 23, 2022

View reviewed changes

TimothyGu reviewed Jan 23, 2022

View reviewed changes

doc/api/url.md Outdated Show resolved Hide resolved

Update doc/api/url.md

ff5b5a4

Co-authored-by: Timothy Gu <timothygu99@gmail.com>

Trott commented Jan 23, 2022

View reviewed changes

lpinca approved these changes Jan 23, 2022

View reviewed changes

RaisinTen approved these changes Jan 23, 2022

View reviewed changes

Mesteery approved these changes Jan 23, 2022

View reviewed changes

Trott mentioned this pull request Jan 24, 2022

new URL() accepts array of string #41653

Closed

benjamingr approved these changes Jan 24, 2022

View reviewed changes

Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 25, 2022

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 25, 2022

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 25, 2022

nodejs-github-bot merged commit 88a3bd5 into nodejs:master Jan 25, 2022

Trott deleted the newurl branch January 25, 2022 02:28

ruyadorno mentioned this pull request Feb 8, 2022

v17.5.0 release proposal #41897

Merged

danielleadams mentioned this pull request Mar 3, 2022

v16.14.1 release proposal #42200

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

doc: clarify treatment of non-string argument to new URL()#41658

doc: clarify treatment of non-string argument to new URL()#41658
nodejs-github-bot merged 2 commits intonodejs:masterfrom
Trott:newurl

Trott commented Jan 23, 2022

Uh oh!

Uh oh!

Trott Jan 23, 2022

Uh oh!

Trott Jan 23, 2022

Uh oh!

nodejs-github-bot commented Jan 25, 2022

Successfully rebased and updated refs/heads/master.

Uh oh!

nodejs-github-bot commented Jan 25, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Uh oh!

Conversation

Trott commented Jan 23, 2022

Uh oh!

Uh oh!

Trott Jan 23, 2022

Choose a reason for hiding this comment

Uh oh!

Trott Jan 23, 2022

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Jan 25, 2022

Successfully rebased and updated refs/heads/master.

Uh oh!

nodejs-github-bot commented Jan 25, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants