tools: disable max-len ESLint rule for strings#41536
Closed
Trott wants to merge 1 commit intonodejs:masterfrom
Closed
tools: disable max-len ESLint rule for strings#41536Trott wants to merge 1 commit intonodejs:masterfrom
Trott wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
needs-ci
benjamingr
approved these changes
Jan 15, 2022
VoltrexKeyva
approved these changes
Jan 15, 2022
himself65
approved these changes
Jan 15, 2022
Mesteery
approved these changes
Jan 15, 2022
VoltrexKeyva
added
author ready
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
Collaborator
jasnell
requested changes
Jan 17, 2022
Member
jasnell
left a comment
jasnell
left a comment
There was a problem hiding this comment.
I'd like to have more discussion on this. I'm not a fan of removing max line lengths. I'm happy to increase the current limits but not so much removing them entirely. I know this PR is limiting that change to just strings but still, I'd like more discussion around this first.
16 tasks
aduh95
removed
the
author ready
13 tasks
Member
Member
Author
|
Member
|
I'm still in favor of this change after #41586 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.