test: improve test coverage of internal/blob

[kuriyosh]

This improves a test coverage in lib/internal/blob
ref: https://coverage.nodejs.org/coverage-74b9baa4265a8f0d/lib/internal/blob.js.html

This added following tests.

• executing inspect to Blob with depth option
• creating new Blob instance with over size argument
• causing ERR_INVALID_THIS errors in some methods

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/41978/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/41994/

[aduh95]

There are several related failures in the CI test results:

AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:
+ actual - expected

+ Comparison {}
- Comparison {
-   code: 'ERR_BUFFER_TOO_LARGE'
- }
    at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-linux/test/parallel/test-blob.js:234:10)
    at Module._compile (node:internal/modules/cjs/loader:1097:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1149:10)
    at Module.load (node:internal/modules/cjs/loader:975:32)
    at Function.Module._load (node:internal/modules/cjs/loader:822:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:77:12)
    at node:internal/main/run_main_module:17:47 {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: RangeError: Array buffer allocation failed
      at new ArrayBuffer (<anonymous>)
      at new Uint8Array (<anonymous>)
      at assert.throws.code (/home/iojs/build/workspace/node-test-commit-linux/test/parallel/test-blob.js:234:33)
      at getActual (node:assert:756:5)
      at Function.throws (node:assert:902:24)
      at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-linux/test/parallel/test-blob.js:234:10)
      at Module._compile (node:internal/modules/cjs/loader:1097:14)
      at Object.Module._extensions..js (node:internal/modules/cjs/loader:1149:10)
      at Module.load (node:internal/modules/cjs/loader:975:32)
      at Function.Module._load (node:internal/modules/cjs/loader:822:12),
  expected: { code: 'ERR_BUFFER_TOO_LARGE' },
  operator: 'throws'
}

Can you take a look please?

[aduh95]

I'm not sure this is a correct fix, the error was RangeError: Array buffer allocation failed, increasing the size would probably not help! A "workaround" would be to skip the test if the memory constraints on the platform doesn't let us run the test, as it's done in some other tests, e.g.

node/test/addons/stringbytes-external-exceed-max/test-stringbytes-external-at-max.js

Lines 16 to 22 in 7d453ff

	try {
	buf = Buffer.allocUnsafe(kStringMaxLength);
	} catch (e) {
	// If the exception is not due to memory confinement then rethrow it.
	if (e.message !== 'Array buffer allocation failed') throw (e);
	common.skip(skipMessage);
	}

[kuriyosh]

@aduh95
I'm sorry to reply late.
Thank you! I didn't know the correct handling in this case, so I took an approach to avoid it by reducing the length of each array passed to the Buffer argument.
I will fix it by the method you suggested!

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/42243/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/43391/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/43395/

[nodejs-github-bot]

Commit Queue failed

- Loading data for nodejs/node/pull/41513
✔  Done loading data for nodejs/node/pull/41513
----------------------------------- PR info ------------------------------------
Title      test: improve test coverage of internal/blob (#41513)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     kuriyosh:test-blob-coverage -> nodejs:master
Labels     test, author ready, needs-ci, commit-queue-squash
Commits    7
 - test: improve test coverage of internal/blob
 - test: over size array in some platforms
 - fix: skip oversized buffer test for memory limitation
 - fix: remove parens in throw statement
 - test: fix mustcall error
 - test: skip invalid array length
 - test: skip this test in freeBSD env
Committers 1
 - Yoshiki Kurihara 
PR-URL: https://github.com/nodejs/node/pull/41513
Refs: https://coverage.nodejs.org/coverage-74b9baa4265a8f0d/lib/internal/blob.js.html
Reviewed-By: Colin Ihrig 
Reviewed-By: Antoine du Hamel 
Reviewed-By: James M Snell 
Reviewed-By: Daijiro Wachi 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/41513
Refs: https://coverage.nodejs.org/coverage-74b9baa4265a8f0d/lib/internal/blob.js.html
Reviewed-By: Colin Ihrig 
Reviewed-By: Antoine du Hamel 
Reviewed-By: James M Snell 
Reviewed-By: Daijiro Wachi 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last review:
   ⚠  - test: skip this test in freeBSD env
   ℹ  This PR was created on Fri, 14 Jan 2022 07:38:07 GMT
   ✔  Approvals: 4
   ✔  - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/41513#pullrequestreview-853117382
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/41513#pullrequestreview-907913460
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/41513#pullrequestreview-907915108
   ✔  - Daijiro Wachi (@watilde): https://github.com/nodejs/node/pull/41513#pullrequestreview-912533681
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2022-04-08T13:38:13Z: https://ci.nodejs.org/job/node-test-pull-request/43395/
- Querying data for job/node-test-pull-request/43395/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/2169804667

[nodejs-github-bot]

Landed in 1285ac1