test,doc: improve fs.access() mode docs and test by cjihrig · Pull Request #41484 · nodejs/node

cjihrig · 2022-01-12T03:06:09Z

test: do not OR F_OK in fs.access() test

access() does not support OR'ing F_OK with other constants.
This commit updates test-fs-access.js to not test that
scenario.

doc: expand fs.access() mode parameter docs

This commit expands the documentation for the mode parameter
passed to the fs.access() family of functions.

~~I'm also going to open a second PR containing a semver major change related to validation code.~~

Refs: libuv/libuv#3410
cc: @zsw007

nodejs-github-bot · 2022-01-13T14:35:30Z

CI: https://ci.nodejs.org/job/node-test-pull-request/41849/

nodejs-github-bot · 2022-01-13T19:25:50Z

CI: https://ci.nodejs.org/job/node-test-pull-request/41853/

nodejs-github-bot · 2022-01-14T16:41:32Z

Commit Queue failed

- Loading data for nodejs/node/pull/41484 ✔ Done loading data for nodejs/node/pull/41484 ----------------------------------- PR info ------------------------------------ Title test,doc: improve fs.access() mode docs and test (#41484) Author Colin Ihrig (@cjihrig) Branch cjihrig:access -> nodejs:master Labels author ready Commits 2 - test: do not OR F_OK in fs.access() test - doc: expand fs.access() mode parameter docs Committers 1 - cjihrig PR-URL: https://github.com/nodejs/node/pull/41484 Refs: https://github.com/libuv/libuv/pull/3410 Reviewed-By: Richard Lau Reviewed-By: Luigi Pinca Reviewed-By: Tobias Nießen ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/41484 Refs: https://github.com/libuv/libuv/pull/3410 Reviewed-By: Richard Lau Reviewed-By: Luigi Pinca Reviewed-By: Tobias Nießen -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 12 Jan 2022 03:06:09 GMT ✔ Approvals: 3 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/41484#pullrequestreview-850371099 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/41484#pullrequestreview-850963333 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/41484#pullrequestreview-851700057 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2022-01-13T19:25:50Z: https://ci.nodejs.org/job/node-test-pull-request/41853/ - Querying data for job/node-test-pull-request/41853/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/master up to date... From https://github.com/nodejs/node * branch master -> FETCH_HEAD ✔ origin/master is now up-to-date - Downloading patch for 41484 From https://github.com/nodejs/node * branch refs/pull/41484/merge -> FETCH_HEAD ✔ Fetched commits as 4dd1f42df6ee..a4f63126fca0 -------------------------------------------------------------------------------- [master dc5c5c8788] test: do not OR F_OK in fs.access() test Author: cjihrig Date: Tue Jan 11 17:53:34 2022 -0500 1 file changed, 3 insertions(+), 3 deletions(-) [master d42df72078] doc: expand fs.access() mode parameter docs Author: cjihrig Date: Tue Jan 11 21:18:50 2022 -0500 1 file changed, 22 insertions(+), 19 deletions(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
test: do not OR F_OK in fs.access() test

access() does not support OR'ing F_OK with other constants.
This commit updates test-fs-access.js to not test that
scenario.

PR-URL: #41484
Refs: libuv/libuv#3410
Reviewed-By: Richard Lau [email protected]
Reviewed-By: Luigi Pinca [email protected]
Reviewed-By: Tobias Nießen [email protected]

[detached HEAD 12e78dff94] test: do not OR F_OK in fs.access() test
Author: cjihrig [email protected]
Date: Tue Jan 11 17:53:34 2022 -0500
1 file changed, 3 insertions(+), 3 deletions(-)
Rebasing (3/4)
Rebasing (4/4)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
doc: expand fs.access() mode parameter docs

This commit expands the documentation for the mode parameter
passed to the fs.access() family of functions.

PR-URL: #41484
Refs: libuv/libuv#3410
Reviewed-By: Richard Lau [email protected]
Reviewed-By: Luigi Pinca [email protected]
Reviewed-By: Tobias Nießen [email protected]

[detached HEAD 6cc025e8d8] doc: expand fs.access() mode parameter docs
Author: cjihrig [email protected]
Date: Tue Jan 11 21:18:50 2022 -0500
1 file changed, 22 insertions(+), 19 deletions(-)

Successfully rebased and updated refs/heads/master.

ℹ Use --fixupAll option, squash the PR manually or land the PR from the command line.

https://github.com/nodejs/node/actions/runs/1698646333

access() does not support OR'ing F_OK with other constants. This commit updates test-fs-access.js to not test that scenario. PR-URL: nodejs#41484 Refs: libuv/libuv#3410 Reviewed-By: Richard Lau Reviewed-By: Luigi Pinca Reviewed-By: Tobias Nießen

This commit expands the documentation for the mode parameter passed to the fs.access() family of functions. PR-URL: nodejs#41484 Refs: libuv/libuv#3410 Reviewed-By: Richard Lau Reviewed-By: Luigi Pinca Reviewed-By: Tobias Nießen

access() does not support OR'ing F_OK with other constants. This commit updates test-fs-access.js to not test that scenario. PR-URL: #41484 Refs: libuv/libuv#3410 Reviewed-By: Richard Lau Reviewed-By: Luigi Pinca Reviewed-By: Tobias Nießen

This commit expands the documentation for the mode parameter passed to the fs.access() family of functions. PR-URL: #41484 Refs: libuv/libuv#3410 Reviewed-By: Richard Lau Reviewed-By: Luigi Pinca Reviewed-By: Tobias Nießen