meta: correct my name in AUTHORS#41444
Merged
nodejs-github-bot merged 2 commits intonodejs:masterfrom Jan 10, 2022
Merged
Conversation
JakobJingleheimer
changed the title
JakobJingleheimer
force-pushed
the
patch-1
branch
2 times, most recently
from
32e57a0 to
7711e5e
Compare
JakobJingleheimer
changed the title
aduh95
approved these changes
Jan 8, 2022
aduh95
added
author ready
Contributor
|
Fast-track has been requested by @aduh95. Please 👍 to approve. |
Ayase-252
approved these changes
Jan 8, 2022
targos
requested changes
Jan 8, 2022
Member
targos
left a comment
targos
left a comment
There was a problem hiding this comment.
Did you rename the file?
There needs to be a change in .mailmap. AUTHORS is automatically generated using it and the git log.
Member
Author
|
What the… no, I didn't (mean to) rename the file. Last time I use GitHub's web editor (that field used to be for naming the branch—now a field for naming the branch is gone, and it's apparently to rename the file 😳) I'll rename it back and update mailmap. Thanks @targos |
JakobJingleheimer
force-pushed
the
patch-1
branch
from
7711e5e to
a82ce70
Compare
Member
Author
|
@targos should I remove the correction in AUTHORS (or will it just get overwritten)? Is it possible to correct it at all? My surname got omitted in some commit (that landed a while ago), and that's what go added to AUTHORS. entry to |
Trott
reviewed
Jan 8, 2022
Trott
approved these changes
Jan 8, 2022
Member
@targos Is this resolved now? |
targos
approved these changes
Jan 10, 2022
aduh95
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in f027463 |
targos
pushed a commit
that referenced
this pull request
Jan 14, 2022
PR-URL: #41444 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Qingyu Deng <i@ayase-lab.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
thedull
pushed a commit
to thedull/node
that referenced
this pull request
Jan 18, 2022
PR-URL: nodejs#41444 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Qingyu Deng <i@ayase-lab.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Linkgoron
pushed a commit
to Linkgoron/node
that referenced
this pull request
Jan 31, 2022
PR-URL: nodejs#41444 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Qingyu Deng <i@ayase-lab.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Feb 1, 2022
PR-URL: #41444 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Qingyu Deng <i@ayase-lab.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My surname is currently missing in AUTHORS list.