tools,benchmark,lib,test: enable no-case-declarations lint rule#41385
Merged
Trott merged 1 commit intonodejs:masterfrom Jan 5, 2022
Merged
tools,benchmark,lib,test: enable no-case-declarations lint rule#41385Trott merged 1 commit intonodejs:masterfrom
Trott merged 1 commit intonodejs:masterfrom
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
lib / src
Trott
added
request-ci
github-actions
bot
removed
the
request-ci
This comment has been minimized.
This comment has been minimized.
Member
|
Do you know if there is (or should be) a predefined rule that enforces that either all or no cases belonging to a |
Member
Author
I'm unaware of anything like that in ESLint core. There might be a third-party module available, and it shouldn't be too hard to write one ourselves. (I'd be -0 on doing that because it's extra maintenance for IMO little benefit. But if you or someone else feels strongly about it, I wouldn't try to persuade you to not do it.) |
This comment has been minimized.
This comment has been minimized.
targos
approved these changes
Jan 3, 2022
aduh95
approved these changes
Jan 3, 2022
tniessen
approved these changes
Jan 3, 2022
Member
tniessen
left a comment
tniessen
left a comment
There was a problem hiding this comment.
LGTM, not sure how I feel about the additional inconsistencies between cases (aesthetically).
Collaborator
bnb
approved these changes
Jan 3, 2022
Contributor
bnb
left a comment
bnb
left a comment
There was a problem hiding this comment.
+1. Also agree with the eventual goal of eslint recommended and happy to see work to get us closer to that :)
25 tasks
rickyes
approved these changes
Jan 4, 2022
cjihrig
approved these changes
Jan 4, 2022
Collaborator
26 tasks
Collaborator
Collaborator
Trott
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/41385 ✔ Done loading data for nodejs/node/pull/41385 ----------------------------------- PR info ------------------------------------ Title tools,benchmark,lib,test: enable no-case-declarations lint rule (#41385) Author Rich Trott (@Trott) Branch Trott:no-case-declaration -> nodejs:master Labels Commits 1 - tools,benchmark,lib,test: enable no-case-declarations lint rule Committers 1 - Rich Trott PR-URL: https://github.com/nodejs/node/pull/41385 Reviewed-By: Michaël Zasso Reviewed-By: Antoine du Hamel Reviewed-By: Tobias Nießen Reviewed-By: Tierney Cyren Reviewed-By: Ricky Zhou <[email protected]> Reviewed-By: Colin Ihrig ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/41385 Reviewed-By: Michaël Zasso Reviewed-By: Antoine du Hamel Reviewed-By: Tobias Nießen Reviewed-By: Tierney Cyren Reviewed-By: Ricky Zhou <[email protected]> Reviewed-By: Colin Ihrig -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 03 Jan 2022 04:26:25 GMT ✔ Approvals: 6 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/41385#pullrequestreview-842509110 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/41385#pullrequestreview-842568613 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/41385#pullrequestreview-842952082 ✔ - Tierney Cyren (@bnb): https://github.com/nodejs/node/pull/41385#pullrequestreview-842990323 ✔ - Ricky Zhou (@rickyes): https://github.com/nodejs/node/pull/41385#pullrequestreview-843192744 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/41385#pullrequestreview-843588295 ✖ GitHub CI is still running ℹ Last Full PR CI on 2022-01-05T14:09:03Z: https://ci.nodejs.org/job/node-test-pull-request/41763/ - Querying data for job/node-test-pull-request/41763/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1659016743 |
PR-URL: nodejs#41385 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Tierney Cyren <[email protected]> Reviewed-By: Ricky Zhou <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Trott
force-pushed
the
no-case-declaration
branch
from
2115a8e to
55ceaec
Compare
Member
Author
|
Landed in 55ceaec |
This was referenced Jan 6, 2022
targos
pushed a commit
that referenced
this pull request
Jan 14, 2022
PR-URL: #41385 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Tierney Cyren <[email protected]> Reviewed-By: Ricky Zhou <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jan 31, 2022
PR-URL: #41385 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Tierney Cyren <[email protected]> Reviewed-By: Ricky Zhou <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Linkgoron
pushed a commit
to Linkgoron/node
that referenced
this pull request
Jan 31, 2022
PR-URL: nodejs#41385 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Tierney Cyren <[email protected]> Reviewed-By: Ricky Zhou <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Feb 1, 2022
PR-URL: #41385 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Tierney Cyren <[email protected]> Reviewed-By: Ricky Zhou <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't leak identifiers into other
casedeclarations. This is an ESLint recommended rule. My goal/hope is to be able to enableeslint:recommendedat some point and have far fewer individual rules specified in.eslintrc.js.