lib: fix checking syntax of esm module#41198
Merged
nodejs-github-bot merged 1 commit intonodejs:masterfrom Dec 19, 2021
Merged
Conversation
DerekNonGeneric
approved these changes
Dec 16, 2021
Contributor
DerekNonGeneric
left a comment
DerekNonGeneric
left a comment
There was a problem hiding this comment.
Well done — it seems like that function invocation should not have been getting destructed — pretty sure that's a good catch and the fix there.
Apologies from @nodejs/loaders (it wasn't me tho). ;)
targos
approved these changes
Dec 16, 2021
richardlau
approved these changes
Dec 16, 2021
cjihrig
approved these changes
Dec 16, 2021
Member
|
Mea culpa 😣 I did a search on the repo and all tests were passing, so I figured all was 👍 Thanks for catching |
lpinca
approved these changes
Dec 16, 2021
jasnell
approved these changes
Dec 17, 2021
tniessen
approved these changes
Dec 19, 2021
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
Collaborator
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 3f7dabd |
20 tasks
This was referenced Dec 21, 2021
targos
pushed a commit
that referenced
this pull request
Jan 14, 2022
Fixes: #41189 PR-URL: #41198 Refs: #37468 Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
danielleadams
pushed a commit
that referenced
this pull request
Jan 31, 2022
Fixes: #41189 PR-URL: #41198 Refs: #37468 Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Linkgoron
pushed a commit
to Linkgoron/node
that referenced
this pull request
Jan 31, 2022
Fixes: nodejs#41189 PR-URL: nodejs#41198 Refs: nodejs#37468 Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
danielleadams
pushed a commit
that referenced
this pull request
Feb 1, 2022
Fixes: #41189 PR-URL: #41198 Refs: #37468 Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A internal function
defaultGetFormatwas changed in #37468. Update the call incheck_syntax.jsaccordingly.Fixes: #41189
Refs: #37468