tools: strip comments from lint-md rollup output#41092
tools: strip comments from lint-md rollup output#41092nodejs-github-bot merged 1 commit intonodejs:masterfrom
Conversation
BridgeAR
left a comment
There was a problem hiding this comment.
Are we certain we keep all necessary copyright / license blocks intact?
Unfortunately, that's a good question. And, in fact, I'm not sure we aren't in license violation already by using rollup but not distributing LICENSE files that come with the code. If that's a problem, then we may need to consider either checking in the entire |
I did a grep for "Permission" and "Copyright" and came up empty. It also leaves |
Although that doesn't answer the question as to whether we should be including LICENSE files etc. But if so, that's already a problem. This PR does not exacerbate it, at least. |
|
Landed in c93a639 |
Refs: #41081 (comment) PR-URL: #41092 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tierney Cyren <hello@bnb.im>
Refs: #41081 (comment) PR-URL: #41092 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tierney Cyren <hello@bnb.im>
Refs: #41081 (comment) PR-URL: #41092 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tierney Cyren <hello@bnb.im>
Refs: #41081 (comment) PR-URL: #41092 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tierney Cyren <hello@bnb.im>
Refs: nodejs#41081 (comment) PR-URL: nodejs#41092 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tierney Cyren <hello@bnb.im>
Refs: #41081 (comment) PR-URL: #41092 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tierney Cyren <hello@bnb.im>
Refs: #41081 (comment)