Conversation
aduh95
left a comment
There was a problem hiding this comment.
Thanks for sending this.
Did you consider adding test cases to test/parallel/test-repl.js instead of creating a new file? We could probably avoid the first lines of boilerplate.
|
|
||
| stream.run([asyncFn]); | ||
| // promise output twice | ||
| output = util.inspect(output).split('\\n> ')[1]; |
There was a problem hiding this comment.
Why are we using util.inspect here?
|
Can you rebase to fix the number of commits in the PR? You can use the following commands to do so: git fetch https://github.com/nodejs/node.git master
git reset FETCH_HEAD --hard
git cherry-pick c5acdd3a07acf62086b71f0e31e45c613c774ecd
git cherry-pick d7579bbfc93b70dc0221067590f5464ff977cd63
git push origin HEAD:master --hardIf you have issues with the rebase, let me know, I might be able to do it for you. |
75d470c to
8ebcb55
Compare
Co-authored-by: Antoine du Hamel <[email protected]>
thank you for detail, i still working in this. there has an error when i use: can i use --force? |
|
Oh yes, I meant force, not hard. |
|
This issue/PR was marked as stalled, it will be automatically closed in 30 days. If it should remain open, please leave a comment explaining why it should remain open. |
|
Closing this because it has stalled. Feel free to reopen if this issue/PR is still relevant, or to ping the collaborator who labelled it stalled if you have any questions. |
add IIFE test for REPL;
Refs: #38685