stream: stricter isReadableNodeStream by ronag · Pull Request #40941 · nodejs/node

I believe the issue is fixed (or at least mitigated somewhat?) by #40934 which was fast-tracked and landed. So it you rebase against master and re-run CI, it should pass.

Trott · 2021-11-26T07:37:48Z

I believe the issue is fixed (or at least mitigated somewhat?) by #40934 which was fast-tracked and landed. So it you rebase against master and re-run CI, it should pass.

Oh, wait, for Jenkins, I don't think you need to rebase. I think a Rebuild rather than a Resume Build will rebase. I'll kick that job off now to see what happens.

nodejs-github-bot · 2021-11-26T07:38:28Z

CI: https://ci.nodejs.org/job/node-test-pull-request/41126/

nodejs-github-bot · 2021-11-26T10:28:00Z

CI: https://ci.nodejs.org/job/node-test-pull-request/41130/

nodejs-github-bot · 2021-11-26T15:25:03Z

CI: https://ci.nodejs.org/job/node-test-pull-request/41138/

nodejs-github-bot · 2021-11-26T16:11:15Z

CI: https://ci.nodejs.org/job/node-test-pull-request/41140/

nodejs-github-bot · 2021-11-26T16:27:16Z

CI: https://ci.nodejs.org/job/node-test-pull-request/41141/ ✅

nodejs-github-bot · 2021-11-26T17:20:52Z

Commit Queue failed

- Loading data for nodejs/node/pull/40941 ✔ Done loading data for nodejs/node/pull/40941 ----------------------------------- PR info ------------------------------------ Title stream: stricter isReadableNodeStream (#40941) Author Robert Nagy (@ronag) Branch ronag:is-readable-strict -> nodejs:master Labels stream, author ready, v17.x Commits 3 - stream: stricter isReadableNodeStream - fixup - fixup: lint Committers 1 - Robert Nagy PR-URL: https://github.com/nodejs/node/pull/40941 Fixes: https://github.com/nodejs/node/issues/40938 Reviewed-By: Matteo Collina Reviewed-By: James M Snell ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/40941 Fixes: https://github.com/nodejs/node/issues/40938 Reviewed-By: Matteo Collina Reviewed-By: James M Snell -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 23 Nov 2021 17:11:36 GMT ✔ Approvals: 2 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/40941#pullrequestreview-814001663 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/40941#pullrequestreview-814084727 ✔ Last GitHub Actions successful ℹ Last Full PR CI on 2021-11-26T16:27:16Z: https://ci.nodejs.org/job/node-test-pull-request/41141/ - Querying data for job/node-test-pull-request/41141/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/master up to date... From https://github.com/nodejs/node * branch master -> FETCH_HEAD ✔ origin/master is now up-to-date - Downloading patch for 40941 From https://github.com/nodejs/node * branch refs/pull/40941/merge -> FETCH_HEAD ✔ Fetched commits as 43e127801425..133cc2c55270 -------------------------------------------------------------------------------- [master d8e39bc26c] stream: stricter isReadableNodeStream Author: Robert Nagy Date: Tue Nov 23 18:11:00 2021 +0100 3 files changed, 22 insertions(+), 2 deletions(-) [master a9a8e95738] fixup Author: Robert Nagy Date: Tue Nov 23 18:20:46 2021 +0100 1 file changed, 1 insertion(+), 3 deletions(-) [master 58fe8c2cba] fixup: lint Author: Robert Nagy Date: Tue Nov 23 18:22:56 2021 +0100 1 file changed, 13 insertions(+), 10 deletions(-) ✔ Patches applied There are 3 commits in the PR. Attempting autorebase. Rebasing (2/6)

Executing: git node land --amend --yes
⚠ Found Fixes: #40938, skipping..
--------------------------------- New Message ----------------------------------
stream: stricter isReadableNodeStream

Fixes: #40938

PR-URL: #40941
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: James M Snell jasnell@gmail.com

[detached HEAD 3df604992c] stream: stricter isReadableNodeStream
Author: Robert Nagy ronagy@icloud.com
Date: Tue Nov 23 18:11:00 2021 +0100
3 files changed, 22 insertions(+), 2 deletions(-)
Rebasing (3/6)
Rebasing (4/6)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
fixup

PR-URL: #40941
Fixes: #40938
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: James M Snell jasnell@gmail.com

[detached HEAD b12ac74f60] fixup
Author: Robert Nagy ronagy@icloud.com
Date: Tue Nov 23 18:20:46 2021 +0100
1 file changed, 1 insertion(+), 3 deletions(-)
Rebasing (5/6)
Rebasing (6/6)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
fixup: lint

PR-URL: #40941
Fixes: #40938
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: James M Snell jasnell@gmail.com

[detached HEAD ba72c05fb0] fixup: lint
Author: Robert Nagy ronagy@icloud.com
Date: Tue Nov 23 18:22:56 2021 +0100
1 file changed, 13 insertions(+), 10 deletions(-)

Successfully rebased and updated refs/heads/master.

ℹ Use --fixupAll option, squash the PR manually or land the PR from the command line.

https://github.com/nodejs/node/actions/runs/1508434363

nodejs-github-bot · 2021-11-26T17:33:07Z

Landed in 49b8c4f

Fixes: #40938 PR-URL: #40941 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

danielleadams · 2022-01-30T22:52:37Z

@ronag is this only for 17.x?

ronag added stream Issues and PRs related to the stream subsystem. v17.x labels Nov 23, 2021

ronag requested a review from mcollina November 23, 2021 17:11

ronag added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 23, 2021

nodejs-github-bot added the needs-ci PRs that need a full CI run. label Nov 23, 2021

ronag removed the needs-ci PRs that need a full CI run. label Nov 23, 2021

mcollina approved these changes Nov 23, 2021

View reviewed changes

ronag force-pushed the is-readable-strict branch from 0b3bdd7 to 5e91917 Compare November 23, 2021 17:13

stream: stricter isReadableNodeStream

da437c1

Fixes: nodejs#40938

ronag force-pushed the is-readable-strict branch from 5e91917 to da437c1 Compare November 23, 2021 17:14

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 23, 2021

mcollina reviewed Nov 23, 2021

View reviewed changes

test/parallel/test-stream-finished.js Outdated Show resolved Hide resolved

fixup

4188695

ronag added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 23, 2021

fixup: lint

133cc2c

ronag force-pushed the is-readable-strict branch from 90d6463 to 133cc2c Compare November 23, 2021 17:23

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 23, 2021

mcollina approved these changes Nov 23, 2021

View reviewed changes

ronag added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 23, 2021

jasnell approved these changes Nov 23, 2021

View reviewed changes

github-actions bot mentioned this pull request Nov 25, 2021

CI Reliability 2021-11-25 nodejs/reliability#128

Open

38 tasks

github-actions bot mentioned this pull request Nov 26, 2021

CI Reliability 2021-11-26 nodejs/reliability#129

Open

33 tasks

Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 26, 2021

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 26, 2021

nodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Nov 26, 2021

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 26, 2021

nodejs-github-bot merged commit 49b8c4f into nodejs:master Nov 26, 2021

github-actions bot mentioned this pull request Nov 27, 2021

CI Reliability 2021-11-27 nodejs/reliability#130

Open

27 tasks

ronag mentioned this pull request Nov 27, 2021

v17.2.0 release proposal #40983

Merged

This was referenced Nov 28, 2021

CI Reliability 2021-11-28 nodejs/reliability#131

Open

CI Reliability 2021-11-29 nodejs/reliability#132

Open

targos pushed a commit that referenced this pull request Nov 29, 2021

stream: stricter isReadableNodeStream

70bd90e

Fixes: #40938 PR-URL: #40941 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

danielleadams added the backport-requested-v16.x label Jan 30, 2022

F3n67u mentioned this pull request Jun 30, 2022

Investigate flaky test-stream-finished #43623

Closed

targos added dont-land-on-v16.x and removed backport-requested-v16.x labels Jul 31, 2022

Uh oh!

Conversation

ronag commented Nov 23, 2021

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Nov 23, 2021

Uh oh!

Uh oh!

nodejs-github-bot commented Nov 23, 2021

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Nov 24, 2021

Uh oh!

nodejs-github-bot commented Nov 25, 2021

Uh oh!

nodejs-github-bot commented Nov 25, 2021

Uh oh!

ronag commented Nov 25, 2021

Uh oh!

nodejs-github-bot commented Nov 26, 2021

Uh oh!

Trott commented Nov 26, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Trott commented Nov 26, 2021

Uh oh!

nodejs-github-bot commented Nov 26, 2021

Uh oh!

nodejs-github-bot commented Nov 26, 2021

Uh oh!

nodejs-github-bot commented Nov 26, 2021

Uh oh!

nodejs-github-bot commented Nov 26, 2021

Uh oh!

nodejs-github-bot commented Nov 26, 2021 • edited by Trott Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Nov 26, 2021

PR-URL: #40941 Reviewed-By: Matteo Collina matteo.collina@gmail.com Reviewed-By: James M Snell jasnell@gmail.com

PR-URL: #40941 Fixes: #40938 Reviewed-By: Matteo Collina matteo.collina@gmail.com Reviewed-By: James M Snell jasnell@gmail.com

PR-URL: #40941 Fixes: #40938 Reviewed-By: Matteo Collina matteo.collina@gmail.com Reviewed-By: James M Snell jasnell@gmail.com

Successfully rebased and updated refs/heads/master.

Uh oh!

nodejs-github-bot commented Nov 26, 2021

Uh oh!

danielleadams commented Jan 30, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Trott commented Nov 26, 2021 •

edited

Loading

nodejs-github-bot commented Nov 26, 2021 •

edited by Trott

Loading

PR-URL: #40941
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: James M Snell jasnell@gmail.com

PR-URL: #40941
Fixes: #40938
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: James M Snell jasnell@gmail.com

PR-URL: #40941
Fixes: #40938
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: James M Snell jasnell@gmail.com