tools: simplify and fix commit queue#40742
Merged
aduh95 merged 4 commits intonodejs:masterfrom Nov 7, 2021
Merged
Conversation
nodejs-github-bot
added
meta
aduh95
approved these changes
Nov 6, 2021
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95
reviewed
Nov 6, 2021
Contributor
|
Fast-track has been requested by @aduh95. Please 👍 to approve. |
targos
commented
Nov 6, 2021
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos
changed the title
VoltrexKeyva
approved these changes
Nov 7, 2021
Contributor
|
Landed in 8731193 |
Contributor
https://github.com/nodejs/node/runs/4131235476?check_suite_focus=true |
Contributor
|
It looks like we need to either go back to using both tokens, or update the permissions of the bot's token. I'll open an issue on nodejs/admin to request the latter, but on the mean time the CQ is broken. |
targos
added a commit
that referenced
this pull request
Nov 8, 2021
Use `gh` CLI for CI and commit queue jobs, and use the correct token to merge PRs. PR-URL: #40742 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
Contributor
|
I temporarily disabled the CQ action until we fix the issue. |
BethGriggs
pushed a commit
that referenced
this pull request
Nov 25, 2021
Use `gh` CLI for CI and commit queue jobs, and use the correct token to merge PRs. PR-URL: #40742 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/cc @nodejs/actions