test: disable warnings to fix flaky test#40739
Closed
aduh95 wants to merge 1 commit intonodejs:masterfrom
Closed
Conversation
nodejs-github-bot
added
needs-ci
github-actions
bot
removed
the
request-ci
This comment has been minimized.
This comment has been minimized.
targos
approved these changes
Nov 6, 2021
Member
targos
left a comment
targos
left a comment
There was a problem hiding this comment.
LGTM, but do you know why the test doesn't fail all the time on all platforms?
Contributor
|
Fast-track has been requested by @targos. Please 👍 to approve. |
Collaborator
Contributor
Author
Note sure, it could be related to something like a race condition between the warning being emitted asynchronously and the process crashing. |
46 tasks
Collaborator
lpinca
approved these changes
Nov 7, 2021
Mesteery
added
the
author ready
46 tasks
Collaborator
Collaborator
Collaborator
Collaborator
Member
|
Landed in a420da6 |
This was referenced Nov 9, 2021
This was referenced Nov 12, 2021
Contributor
aduh95
added a commit
to aduh95/node
that referenced
this pull request
Jan 30, 2022
Fixes: nodejs#40738 PR-URL: nodejs#40739 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95
added a commit
to aduh95/node
that referenced
this pull request
Jan 31, 2022
Fixes: nodejs#40738 PR-URL: nodejs#40739 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #40738