fix: Blob constructor on various ArrayBuffer views

[Gozala]

Fixes #40705

[devsnek]

please add a test! the likely file is tests/parallel/test-blob.js

[Gozala]

please add a test! the likely file is tests/parallel/test-blob.js

I was just looking into it and discovered that there is actually a test that supposed to catch this

node/test/fixtures/wpt/FileAPI/blob/Blob-constructor.any.js

Lines 285 to 299 in dd52c05

	test_blob(function() {
	return new Blob([
	new Uint8Array([0x50, 0x41, 0x53, 0x53]),
	new Int8Array([0x50, 0x41, 0x53, 0x53]),
	new Uint16Array([0x4150, 0x5353]),
	new Int16Array([0x4150, 0x5353]),
	new Uint32Array([0x53534150]),
	new Int32Array([0x53534150]),
	new Float32Array([0xD341500000])
	]);
	}, {
	expected: "PASSPASSPASSPASSPASSPASSPASS",
	type: "",
	desc: "Passing typed arrays as elements of the blobParts array should work."
	});

I'm not sure how is it not failing, or maybe it's skipped somehow

[Gozala]

Ok looks like test that would have caught this are disabled here
https://github.com/nodejs/node/blob/master/test/wpt/status/FileAPI/blob.json

[Gozala]

I was unable to enable constructor test because there was dependency on FileReader API, instead I just ported that test to tests/parallel/test-blob.js.

[aduh95]

Try running make lint-js-fix to fix the linter errors. To test if your test is passing before pushing, you can run make -j4 && tools/test.py test/parallel/test-blob.

[Gozala]

@aduh95 all issues have been addressed

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/40712/

[aduh95]

It'd be nice to have a comment referencing where this test is coming from.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/41442/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/41451/

[nodejs-github-bot]

Commit Queue failed

- Loading data for nodejs/node/pull/40706
✔  Done loading data for nodejs/node/pull/40706
----------------------------------- PR info ------------------------------------
Title      fix: Blob constructor on various ArrayBuffer views (#40706)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     Gozala:patch-1 -> nodejs:master
Labels     buffer, author ready, commit-queue-squash
Commits    8
 - fix: Blob constructor on various ArrayBuffer views
 - fix: only copy necessary bytes
 - chore: add test case
 - fix: slice buffer from both sides
 - Update test/parallel/test-blob.js
 - fix: address lint & test errors
 - fix: lint error at test/parallel/test-blob.js
 - chore: fix test failures for big endian hosts
Committers 1
 - GitHub 
PR-URL: https://github.com/nodejs/node/pull/40706
Reviewed-By: Robert Nagy 
Reviewed-By: Antoine du Hamel 
Reviewed-By: Minwoo Jung 
Reviewed-By: James M Snell 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/40706
Reviewed-By: Robert Nagy 
Reviewed-By: Antoine du Hamel 
Reviewed-By: Minwoo Jung 
Reviewed-By: James M Snell 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 02 Nov 2021 21:28:04 GMT
   ✔  Approvals: 4
   ✔  - Robert Nagy (@ronag) (TSC): https://github.com/nodejs/node/pull/40706#pullrequestreview-798208662
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/40706#pullrequestreview-798326412
   ✔  - Minwoo Jung (@JungMinu): https://github.com/nodejs/node/pull/40706#pullrequestreview-798468938
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/40706#pullrequestreview-816263801
   ✔  Last GitHub Actions successful
   ℹ  Last Full PR CI on 2021-12-10T15:19:04Z: https://ci.nodejs.org/job/node-test-pull-request/41451/
- Querying data for job/node-test-pull-request/41451/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/master up to date...
From https://github.com/nodejs/node
 * branch                  master     -> FETCH_HEAD
✔  origin/master is now up-to-date
- Downloading patch for 40706
From https://github.com/nodejs/node
 * branch                  refs/pull/40706/merge -> FETCH_HEAD
✔  Fetched commits as ef7a686ed996..df6ad221669f
--------------------------------------------------------------------------------
Auto-merging lib/internal/blob.js
[master 6f3fb5ad28] fix: Blob constructor on various ArrayBuffer views
 Author: Irakli Gozalishvili 
 Date: Tue Nov 2 14:24:41 2021 -0700
 1 file changed, 1 insertion(+), 1 deletion(-)
Auto-merging lib/internal/blob.js
[master e88738c090] fix: only copy necessary bytes
 Author: Irakli Gozalishvili 
 Date: Tue Nov 2 14:32:36 2021 -0700
 1 file changed, 1 insertion(+), 1 deletion(-)
Auto-merging test/parallel/test-blob.js
[master c43f351acb] chore: add test case
 Author: Irakli Gozalishvili 
 Date: Tue Nov 2 21:57:24 2021 +0000
 1 file changed, 15 insertions(+)
Auto-merging lib/internal/blob.js
[master df00b952b1] fix: slice buffer from both sides
 Author: Irakli Gozalishvili 
 Date: Wed Nov 3 05:03:33 2021 +0000
 1 file changed, 4 insertions(+), 4 deletions(-)
Auto-merging test/parallel/test-blob.js
[master 11380e6481] Update test/parallel/test-blob.js
 Author: Irakli Gozalishvili 
 Date: Wed Nov 3 08:57:24 2021 -0700
 1 file changed, 1 insertion(+), 1 deletion(-)
Auto-merging lib/internal/blob.js
Auto-merging test/parallel/test-blob.js
[master 92f521986c] fix: address lint & test errors
 Author: Irakli Gozalishvili 
 Date: Wed Nov 3 08:58:24 2021 -0700
 2 files changed, 4 insertions(+), 4 deletions(-)
Auto-merging test/parallel/test-blob.js
[master 66df80bb8d] fix: lint error at test/parallel/test-blob.js
 Author: Irakli Gozalishvili 
 Date: Wed Nov 3 14:06:22 2021 -0700
 1 file changed, 1 insertion(+), 1 deletion(-)
Auto-merging test/parallel/test-blob.js
[master e9ee2b5b9a] chore: fix test failures for big endian hosts
 Author: Irakli Gozalishvili 
 Date: Mon Nov 8 12:55:39 2021 -0800
 1 file changed, 1 insertion(+), 1 deletion(-)
   ✔  Patches applied
There are 8 commits in the PR. Attempting to fixup everything into first commit.
[master f5479c4aa0] fix: Blob constructor on various ArrayBuffer views
 Author: Irakli Gozalishvili 
 Date: Tue Nov 2 14:24:41 2021 -0700
 2 files changed, 19 insertions(+), 4 deletions(-)
--------------------------------- New Message ----------------------------------
fix: Blob constructor on various ArrayBuffer views
Fixes #40705
PR-URL: #40706

Reviewed-By: Robert Nagy ronagy@icloud.com

Reviewed-By: Antoine du Hamel duhamelantoine1995@gmail.com

Reviewed-By: Minwoo Jung nodecorelab@gmail.com

Reviewed-By: James M Snell jasnell@gmail.com
[master f9a08f516e] fix: Blob constructor on various ArrayBuffer views

Author: Irakli Gozalishvili contact@gozala.io

Date: Tue Nov 2 14:24:41 2021 -0700

2 files changed, 19 insertions(+), 4 deletions(-)

✖  f9a08f516e6d5288ee3ff071c19c23c0eae2d8ce

✔  0:0      skipping fixes-url                        fixes-url

✔  0:0      blank line after title                    line-after-title

✔  0:0      line-lengths are valid                    line-length

✔  0:0      metadata is at end of message             metadata-end

✔  3:8      PR-URL is valid.                          pr-url

✔  0:0      reviewers are valid                       reviewers

✖  0:0      Invalid subsystem: "fix"                  subsystem

✖  0:6      First word after subsystem(s) in title should be lowercase. title-format

✔  0:0      Title is <= 50 columns.                   title-length

ℹ  Please fix the commit message and try again.

https://github.com/nodejs/node/actions/runs/1565588702

[aduh95]

Landed in 2e1fa8a