src: add and fix some preprocessor comments#40701
Closed
tniessen wants to merge 1 commit intonodejs:masterfrom
Closed
src: add and fix some preprocessor comments#40701tniessen wants to merge 1 commit intonodejs:masterfrom
tniessen wants to merge 1 commit intonodejs:masterfrom
Conversation
tniessen
added
the
c++
nodejs-github-bot
added
lib / src
github-actions
bot
removed
the
request-ci
This comment has been minimized.
This comment has been minimized.
Collaborator
43 tasks
lpinca
approved these changes
Nov 5, 2021
addaleax
approved these changes
Nov 5, 2021
44 tasks
tniessen
added
the
commit-queue
Member
Author
|
Thank you for reviewing. |
github-actions
bot
removed
the
commit-queue
46 tasks
tniessen
added
the
commit-queue
46 tasks
JungMinu
approved these changes
Nov 8, 2021
23 tasks
tniessen
added
the
author ready
Member
Author
|
Landed in 5e0dd79. |
tniessen
added a commit
that referenced
this pull request
Nov 10, 2021
PR-URL: #40701 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
targos
pushed a commit
that referenced
this pull request
Nov 21, 2021
PR-URL: #40701 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 30, 2022
PR-URL: #40701 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Feb 1, 2022
PR-URL: #40701 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Merged
panva
removed
the
commit-queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes some comments related to preprocessor directives.
It also adds a few comments where the relation of
#endifto the corresponding#if/#ifdef/#elseis difficult to see (mostly because of the number of lines of code between the opening and closing directives).