deps: update c-ares to 1.18.1 by richardlau · Pull Request #40660 · nodejs/node

richardlau · 2021-10-29T18:38:31Z

Add a script to automate updating of the c-ares dependency and accompanying maintenance guide and use the script to update to c-ares 1.18.1.

I've opted to strip out the c-ares tests for space reasons (3 mb, and we didn't include them before). Other than that the script minimize the differences between what is in our source tree compared to the upstream c-ares tar balls, which does mean things being added that we did not have before (e.g. c-ares docs).

nodejs-github-bot · 2021-10-29T18:51:37Z

CI: https://ci.nodejs.org/job/node-test-pull-request/40566/

Trott

Rubber-stamp LGTM if CI is green.

~~We'll want to add this to the tools.yml file in #40644.~~

Trott · 2021-10-29T21:39:06Z

We'll want to add this to the tools.yml file in #40644.

Oh wait, no we won't because this is a dependency rather than a tool.

nodejs-github-bot · 2021-10-29T21:59:43Z

CI: https://ci.nodejs.org/job/node-test-pull-request/40570/

doc/guides/maintaining-c-ares.md

Trott · 2021-10-31T05:17:52Z

doc/guides/maintaining-c-ares.md

+1. Unpacking the source in a temporary workspace directory.
+1. Removing the `test` directory (to save disk space).
+1. Copying over the existing `.gitignore`, pre-generated `config` directory and


Suggested change

1. Unpacking the source in a temporary workspace directory.

1. Removing the `test` directory (to save disk space).

1. Copying over the existing `.gitignore`, pre-generated `config` directory and

2. Unpacking the source in a temporary workspace directory.

3. Removing the `test` directory (to save disk space).

4. Copying over the existing `.gitignore`, pre-generated `config` directory and

I don't understand why we want to do that. It's a feature of markdown to write ordered lists only with ones, and I like it because it allows to add an item anywhere in the list without having te renumber everything after it.

I've run the formatter and committed the results (plus the comma change and reworded the bit about LICENSE updates). I kind of agree with @targos re. the GitHub flavored markdown feature but I'm not going to fight the formatter.

@targos @richardlau This is a bit of a spaces vs. tabs kind of thing I suppose, but for what it's worth, I think it's better to format it this way so that the raw markdown is more easily readable. It's supposed to be one of the advantages of markdown that it is useable/understandable in its raw format. It makes things slightly harder for the author, but I think when the differences are small, we should favor the reader. (That said, I haven't looked to see if there is a configuration option in remark to change this behavior. There might be.)

(And I also don't actually feel strongly about it. We do more writing markdown than reading the raw markdown probably, so... I'm just going to submit to the formatter... ¯\(ツ)/¯ )

Trott · 2021-10-31T05:18:28Z

doc/guides/maintaining-c-ares.md

+1. Replacing the existing `deps/cares` with the workspace directory.
+1. Modifying the `cares.gyp` file for file additions/deletions.
+1. Rebuilding the main Node.js `LICENSE`.


Suggested change

1. Replacing the existing `deps/cares` with the workspace directory.

1. Modifying the `cares.gyp` file for file additions/deletions.

1. Rebuilding the main Node.js `LICENSE`.

5. Replacing the existing `deps/cares` with the workspace directory.

6. Modifying the `cares.gyp` file for file additions/deletions.

7. Rebuilding the main Node.js `LICENSE`.

Trott · 2021-10-31T05:18:59Z

doc/guides/maintaining-c-ares.md

+./tools/update-cares.sh x.y.z
+```
+
+e.g.


Suggested change

e.g.

e.g.

Trott · 2021-10-31T05:19:32Z

doc/guides/maintaining-c-ares.md

+./tools/license-builder.sh
+```
+
+If the `LICENSE` is updated for changes other than this c-ares update those


Suggested change

If the `LICENSE` is updated for changes other than this c-ares update those

If the `LICENSE` is updated for changes other than this c-ares update, those

Trott · 2021-10-31T05:20:16Z

doc/guides/maintaining-c-ares.md

+git add -A deps/cares
+```
+
+Add the rebuilt `LICENSE` if it has been updated.


Suggested change

Add the rebuilt `LICENSE` if it has been updated.

Add the rebuilt `LICENSE` if it has been updated.

Add a script to automate updating of the c-ares dependency and accompanying maintenance guide. PR-URL: #40660 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com>

Updated as described in doc/guides/maintaining-c-ares.md. PR-URL: #40660 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com>

Add a script to automate updating of the c-ares dependency and accompanying maintenance guide. PR-URL: #40660 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com>

Updated as described in doc/guides/maintaining-c-ares.md. PR-URL: #40660 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com>

Add a script to automate updating of the c-ares dependency and accompanying maintenance guide. PR-URL: #40660 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com>

Updated as described in doc/guides/maintaining-c-ares.md. PR-URL: #40660 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com>

Add a script to automate updating of the c-ares dependency and accompanying maintenance guide. PR-URL: #40660 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com>

Updated as described in doc/guides/maintaining-c-ares.md. PR-URL: #40660 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com>

Notable changes: - **deps**: upgrade npm to 8.1.2 (npm team) [#40643](#40643) - **deps**: update c-ares to 1.18.1 (Richard Lau) [#40660](#40660) - **doc**: add VoltrexMaster to collaborators (voltrexmaster) [#40566](#40566) - **lib**: fix regular expression to detect \`/\` and \`\\\` (Francesco Trotta) [#40325](#40325) PR-URL: #40974

Add a script to automate updating of the c-ares dependency and accompanying maintenance guide. PR-URL: #40660 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com>

Updated as described in doc/guides/maintaining-c-ares.md. PR-URL: #40660 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com>

Notable changes: - **deps**: upgrade npm to 8.1.2 (npm team) [nodejs#40643](nodejs#40643) - **deps**: update c-ares to 1.18.1 (Richard Lau) [nodejs#40660](nodejs#40660) - **doc**: add VoltrexMaster to collaborators (voltrexmaster) [nodejs#40566](nodejs#40566) - **lib**: fix regular expression to detect \`/\` and \`\\\` (Francesco Trotta) [nodejs#40325](nodejs#40325) PR-URL: nodejs#40974

nodejs-github-bot added cares Issues and PRs related to the c-ares dependency or the cares_wrap binding. needs-ci PRs that need a full CI run. labels Oct 29, 2021

richardlau added request-ci Add this label to start a Jenkins CI on a PR. lts-watch-v12.x and removed cares Issues and PRs related to the c-ares dependency or the cares_wrap binding. needs-ci PRs that need a full CI run. labels Oct 29, 2021

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 29, 2021

This comment has been minimized.

Sign in to view

richardlau force-pushed the cares branch from ab9566b to d43580d Compare October 29, 2021 18:47

richardlau added cares Issues and PRs related to the c-ares dependency or the cares_wrap binding. needs-ci PRs that need a full CI run. request-ci Add this label to start a Jenkins CI on a PR. labels Oct 29, 2021

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 29, 2021

Trott approved these changes Oct 29, 2021

View reviewed changes

This was referenced Oct 30, 2021

CI Reliability 2021-10-30 nodejs/reliability#102

Open

CI Reliability 2021-10-31 nodejs/reliability#103

Open

tniessen approved these changes Oct 31, 2021

View reviewed changes

doc/guides/maintaining-c-ares.md Outdated Show resolved Hide resolved

doc/guides/maintaining-c-ares.md Outdated Show resolved Hide resolved

Trott reviewed Oct 31, 2021

View reviewed changes

doc/guides/maintaining-c-ares.md

./tools/update-cares.sh x.y.z

```

e.g.

Copy link

Member

Trott Oct 31, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

e.g.

e.g.

Trott reviewed Oct 31, 2021

View reviewed changes

targos approved these changes Oct 31, 2021

View reviewed changes

github-actions bot mentioned this pull request Nov 1, 2021

CI Reliability 2021-11-01 nodejs/reliability#104

Open

38 tasks

richardlau mentioned this pull request Nov 1, 2021

NodeJS Inconsistent response from the DNS library #40690

Closed

This was referenced Nov 3, 2021

CI Reliability 2021-11-03 nodejs/reliability#106

Open

CI Reliability 2021-11-04 nodejs/reliability#107

Open

CI Reliability 2021-11-05 nodejs/reliability#108

Open

CI Reliability 2021-11-06 nodejs/reliability#109

Open

github-actions bot mentioned this pull request Nov 7, 2021

CI Reliability 2021-11-07 nodejs/reliability#110

Open

46 tasks

targos mentioned this pull request Nov 8, 2021

v17.1.0 release proposal #40758

Merged

Ayase-252 mentioned this pull request Nov 18, 2021

Unable to resolve A when record points to CNAME containing underscore #39780

Closed

richardlau mentioned this pull request Nov 25, 2021

v14.18.2 proposal #40969

Merged

BethGriggs mentioned this pull request Nov 26, 2021

v16.13.1 proposal #40974

Merged

1 task

richardlau added backported-to-v14.x and removed lts-watch-v14.x labels Nov 26, 2021

richardlau added backported-to-v12.x and removed lts-watch-v12.x labels Dec 9, 2021

richardlau mentioned this pull request Dec 13, 2021

v12.22.8 proposal #41161

Merged

	If the `LICENSE` is updated for changes other than this c-ares update those
	If the `LICENSE` is updated for changes other than this c-ares update, those

	Add the rebuilt `LICENSE` if it has been updated.
	Add the rebuilt `LICENSE` if it has been updated.

Uh oh!

Conversation

richardlau commented Oct 29, 2021

Uh oh!

This comment has been minimized.

nodejs-github-bot commented Oct 29, 2021

Uh oh!

Trott left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Trott commented Oct 29, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Oct 29, 2021

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Trott left a comment •

edited

Loading

Trott commented Oct 29, 2021 •

edited

Loading