stream: rename unknown primordial#40622
Closed
VoltrexKeyva wants to merge 2 commits intonodejs:masterfrom
Closed
Conversation
VoltrexKeyva
force-pushed
the
fix-unknown-primordial
branch
from
ab71cf8 to
b75b382
Compare
VoltrexKeyva
changed the title
VoltrexKeyva
added
stream
github-actions
bot
removed
the
request-ci
This comment has been minimized.
This comment has been minimized.
Contributor
|
We should probably add a test for this. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
VoltrexKeyva
force-pushed
the
fix-unknown-primordial
branch
from
d66a7ce to
f38592d
Compare
This comment has been minimized.
This comment has been minimized.
Member
Author
|
This is strange, our |
Member
It's probably a bug in the rule. |
aduh95
added a commit
to aduh95/node
that referenced
this pull request
Oct 27, 2021
aduh95
added a commit
to aduh95/node
that referenced
this pull request
Oct 27, 2021
Contributor
It is, fix in #40628. |
30 tasks
jasnell
approved these changes
Oct 28, 2021
33 tasks
tniessen
approved these changes
Oct 29, 2021
aduh95
added a commit
to nodejs/node-auto-test
that referenced
this pull request
Oct 29, 2021
commit 958a05db7e7d9ec62e3aea119aad10c7cfd39ba6 Author: Antoine du Hamel <[email protected]> Date: Wed Oct 27 16:17:05 2021 +0200 tools: fix bug in `prefer-primordials` ESLint rule Refs: nodejs/node#40622 PR-URL: nodejs/node#40628 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Voltrex <[email protected]> Reviewed-By: James M Snell <[email protected]>
This was referenced Oct 30, 2021
aduh95
approved these changes
Jan 19, 2022
github-actions
bot
removed
the
request-ci
This comment has been minimized.
This comment has been minimized.
17 tasks
Collaborator
aduh95
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 5753eb1...de9dc41 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Jan 20, 2022
The primordials does not expose a primordial called `DataViewCtor`, leading up to a non-existent constructor. Fixes: #40612 PR-URL: #40622 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
nodejs-github-bot
pushed a commit
that referenced
this pull request
Jan 20, 2022
The WHATWG `ReadableStream` test needs a new test entry for reading a `DataView`. PR-URL: #40622 Fixes: #40612 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
19 tasks
BethGriggs
pushed a commit
that referenced
this pull request
Jan 25, 2022
The primordials does not expose a primordial called `DataViewCtor`, leading up to a non-existent constructor. Fixes: #40612 PR-URL: #40622 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Jan 25, 2022
The WHATWG `ReadableStream` test needs a new test entry for reading a `DataView`. PR-URL: #40622 Fixes: #40612 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Linkgoron
pushed a commit
to Linkgoron/node
that referenced
this pull request
Jan 31, 2022
The primordials does not expose a primordial called `DataViewCtor`, leading up to a non-existent constructor. Fixes: nodejs#40612 PR-URL: nodejs#40622 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Linkgoron
pushed a commit
to Linkgoron/node
that referenced
this pull request
Jan 31, 2022
The WHATWG `ReadableStream` test needs a new test entry for reading a `DataView`. PR-URL: nodejs#40622 Fixes: nodejs#40612 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Feb 28, 2022
The primordials does not expose a primordial called `DataViewCtor`, leading up to a non-existent constructor. Fixes: #40612 PR-URL: #40622 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Feb 28, 2022
The WHATWG `ReadableStream` test needs a new test entry for reading a `DataView`. PR-URL: #40622 Fixes: #40612 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Mar 2, 2022
The primordials does not expose a primordial called `DataViewCtor`, leading up to a non-existent constructor. Fixes: #40612 PR-URL: #40622 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Mar 2, 2022
The WHATWG `ReadableStream` test needs a new test entry for reading a `DataView`. PR-URL: #40622 Fixes: #40612 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Mar 3, 2022
The primordials does not expose a primordial called `DataViewCtor`, leading up to a non-existent constructor. Fixes: #40612 PR-URL: #40622 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Mar 3, 2022
The WHATWG `ReadableStream` test needs a new test entry for reading a `DataView`. PR-URL: #40622 Fixes: #40612 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Mar 14, 2022
The primordials does not expose a primordial called `DataViewCtor`, leading up to a non-existent constructor. Fixes: #40612 PR-URL: #40622 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Mar 14, 2022
The WHATWG `ReadableStream` test needs a new test entry for reading a `DataView`. PR-URL: #40622 Fixes: #40612 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The primordials does not expose a primordial called
DataViewCtor, leading up to a non-existent constructor.Fixes: #40612