doc: correct esm spec package scope lookup definition#40592
Closed
guybedford wants to merge 1 commit intonodejs:masterfrom
Closed
doc: correct esm spec package scope lookup definition#40592guybedford wants to merge 1 commit intonodejs:masterfrom
guybedford wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
doc
1 task
guybedford
force-pushed
the
spec-scope-fix
branch
from
54656f5 to
f6b641d
Compare
targos
approved these changes
Oct 25, 2021
Mesteery
added
the
author ready
aduh95
approved these changes
Oct 25, 2021
GeoffreyBooth
approved these changes
Oct 25, 2021
Contributor
Author
|
Landed in 687debb. |
guybedford
added a commit
that referenced
this pull request
Oct 26, 2021
PR-URL: #40592 Fixes: #40578 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]>
targos
pushed a commit
that referenced
this pull request
Nov 6, 2021
PR-URL: #40592 Fixes: #40578 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jan 29, 2022
PR-URL: #40592 Fixes: #40578 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This corrects the logic in the
READ_PACKAGE_SCOPEmethod where it was returning the parsed package.json contents instead of the URL followed by a second read phase. In the processREAD_PACKAGE_SCOPEhas been renamed toLOOKUP_PACKAGE_SCOPEto more clearly reflect the definition of this return value.Fixes: #40578
@nodejs/modules