[v12.x backport] lib: fix regular expression to detect / and \#40565
Closed
aduh95 wants to merge 1 commit intonodejs:v12.x-stagingfrom
Closed
[v12.x backport] lib: fix regular expression to detect / and \#40565aduh95 wants to merge 1 commit intonodejs:v12.x-stagingfrom
/ and \#40565aduh95 wants to merge 1 commit intonodejs:v12.x-stagingfrom
Conversation
PR-URL: nodejs#40325 Fixes: nodejs#40305 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>
github-actions
bot
added
esm
Collaborator
DerekNonGeneric
approved these changes
Dec 14, 2021
Collaborator
richardlau
approved these changes
Dec 14, 2021
richardlau
pushed a commit
that referenced
this pull request
Dec 14, 2021
PR-URL: #40325 Backport-PR-URL: #40565 Fixes: #40305 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>
Member
|
Landed in 243b2fb. |
This was referenced Dec 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #40325