Skip to content

doc: simplify CHANGELOG.md#40475

Closed
Trott wants to merge 1 commit intonodejs:masterfrom
Trott:changelog-de-sup
Closed

doc: simplify CHANGELOG.md#40475
Trott wants to merge 1 commit intonodejs:masterfrom
Trott:changelog-de-sup

Conversation

@Trott
Copy link
Member

@Trott Trott commented Oct 16, 2021

Remove unnecessary <sup> usage and lint-disabling comment.

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Oct 16, 2021
@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 16, 2021
aduh95
aduh95 approved these changes Oct 16, 2021
View reviewed changes
Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note this will conflct with #40119, and should probably not land until the release is out.

@richardlau
Copy link
Member

richardlau commented Oct 16, 2021

Note this will conflct with #40119, and should probably not land until the release is out.

It will also cause a conflict when we merge the changelog changes for the yet-to-be-opened 16 LTS transition release.

@Trott
Copy link
Member Author

Trott commented Oct 20, 2021

Note this will conflct with #40119, and should probably not land until the release is out.

Rebased and resolved that conflict.

I guess this should also wait for 16.x to switch to LTS before landing so that conflict can be resolved too? @richardlau

@richardlau
Copy link
Member

richardlau commented Oct 20, 2021 •
edited
Loading

I guess this should also wait for 16.x to switch to LTS before landing so that conflict can be resolved too? @richardlau

It would make things easier for me if this waited until after the 16 LTS transition🙂.

mhdawson
mhdawson approved these changes Oct 20, 2021
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Trott Trott added the blocked PRs that are blocked by other issues or PRs. label Oct 20, 2021
@Trott
Copy link
Member Author

Trott commented Oct 20, 2021

Added blocked label. Can be removed after 16.x transitions to LTS.

@richardlau richardlau mentioned this pull request Oct 20, 2021
Merged
@aduh95 aduh95 mentioned this pull request Oct 23, 2021
Merged
@richardlau richardlau removed the blocked PRs that are blocked by other issues or PRs. label Oct 26, 2021
@Trott
doc: simplify CHANGELOG.md
7c2317d 
Remove unnecessary `<sup>` usage and lint-disabling comment.
@richardlau richardlau mentioned this pull request Oct 26, 2021
Merged
@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 26, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 26, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Oct 26, 2021

Landed in 687debb...9c405f2

@github-actions github-actions bot closed this Oct 26, 2021
nodejs-github-bot pushed a commit that referenced this pull request Oct 26, 2021
@Trott @nodejs-github-bot
doc: simplify CHANGELOG.md
9c405f2 
Remove unnecessary `<sup>` usage and lint-disabling comment.

PR-URL: #40475
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@Trott Trott deleted the changelog-de-sup branch October 26, 2021 23:37
richardlau added a commit to richardlau/node-core-utils that referenced this pull request Oct 27, 2021
@richardlau
fix: update for recent changelog format change
2d83847 
The Node.js `CHANGELOG.md` has replaced use of `<sup>` tags.

Refs: nodejs/node#40475
@richardlau richardlau mentioned this pull request Oct 27, 2021
Merged
richardlau added a commit to nodejs/node-core-utils that referenced this pull request Oct 28, 2021
@richardlau
fix: update for recent changelog format change (#576)
8f1fa9c 
The Node.js `CHANGELOG.md` has replaced use of `<sup>` tags.

Refs: nodejs/node#40475
targos pushed a commit that referenced this pull request Nov 6, 2021
@Trott @targos
doc: simplify CHANGELOG.md
5951ccc 
Remove unnecessary `<sup>` usage and lint-disabling comment.

PR-URL: #40475
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@targos targos mentioned this pull request Nov 8, 2021
Merged
danielleadams pushed a commit that referenced this pull request Jan 29, 2022
@Trott @danielleadams
doc: simplify CHANGELOG.md
fe1b6fb 
Remove unnecessary `<sup>` usage and lint-disabling comment.

PR-URL: #40475
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
Merged
johnfrench3 pushed a commit to johnfrench3/core-utils-node that referenced this pull request Nov 2, 2022
fix: update for recent changelog format change (#576)
bb68a88 
The Node.js `CHANGELOG.md` has replaced use of `<sup>` tags.

Refs: nodejs/node#40475
renawolford6 added a commit to renawolford6/node-dev-build-core-utils that referenced this pull request Nov 10, 2022
@renawolford6
fix: update for recent changelog format change (#576)
ec71b9a 
The Node.js `CHANGELOG.md` has replaced use of `<sup>` tags.

Refs: nodejs/node#40475
Developerarif2 pushed a commit to Developerarif2/node-core-utils that referenced this pull request Jan 27, 2023
@logictitans
fix: update for recent changelog format change (#576)
99e5cb5 
The Node.js `CHANGELOG.md` has replaced use of `<sup>` tags.

Refs: nodejs/node#40475
gerkai added a commit to gerkai/node-core-utils-project-build that referenced this pull request Jan 27, 2023
@gerkai
fix: update for recent changelog format change (#576)
7b557ca 
The Node.js `CHANGELOG.md` has replaced use of `<sup>` tags.

Refs: nodejs/node#40475
patrickm68 added a commit to patrickm68/NodeJS-core-utils that referenced this pull request Sep 14, 2023
@patrickm68
fix: update for recent changelog format change (#576)
52b2586 
The Node.js `CHANGELOG.md` has replaced use of `<sup>` tags.

Refs: nodejs/node#40475
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@targos targos targos approved these changes

@richardlau richardlau richardlau approved these changes

@mhdawson mhdawson mhdawson approved these changes

@aduh95 aduh95 aduh95 approved these changes

@trivikr trivikr trivikr approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. meta Issues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@Trott @richardlau @jasnell @lpinca @targos @mhdawson @aduh95 @trivikr @nodejs-github-bot