Skip to content

tools: update ESLint to 8.0.0#40394

Merged
Trott merged 7 commits intonodejs:masterfrom
Trott:eslint-update-8.0.0
Oct 12, 2021
Merged

tools: update ESLint to 8.0.0#40394
Trott merged 7 commits intonodejs:masterfrom
Trott:eslint-update-8.0.0

Conversation

@Trott
Copy link
Member

@Trott Trott commented Oct 10, 2021

No description provided.

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Oct 10, 2021
@Trott Trott force-pushed the eslint-update-8.0.0 branch 4 times, most recently from ee9dfb1 to 32b353d Compare October 10, 2021 01:44
@Trott Trott mentioned this pull request Oct 10, 2021
Closed
@Mesteery Mesteery added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 10, 2021
aduh95
aduh95 approved these changes Oct 10, 2021
View reviewed changes
Copy link
Contributor

@aduh95 aduh95 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: 0463afb and ada8b26 could be squashed together as it's related to the npm upgrade and should probably have landed as part of #40369 IIUC.

@Trott Trott force-pushed the eslint-update-8.0.0 branch from 38e6e18 to cf7749f Compare October 10, 2021 14:20
@Trott
Copy link
Member Author

Trott commented Oct 10, 2021 •
edited
Loading

nit: 0463afb and ada8b26 could be squashed together as it's related to the npm upgrade and should probably have landed as part of #40369 IIUC.

I agree. Squashed.

lpinca
lpinca approved these changes Oct 11, 2021
View reviewed changes
Copy link
Member

@lpinca lpinca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 12, 2021
Trott added 7 commits October 11, 2021 18:37
@Trott
tools: fix ESLint update scripts
0a1b399 
Changes to the npm dependency in the core repo require changes to
update-eslint.sh and update-bable-eslint.sh.

PR-URL: nodejs#40394
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Trott
tools: prepare ESLint rules for 8.0.0 requirements
dd8e219 
PR-URL: nodejs#40394
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Trott
tools: update ESLint to 8.0.0
8ca76eb 
PR-URL: nodejs#40394
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Trott
tools: remove @babel/plugin-syntax-top-level-await
a6fd39f 
ESLint 8.0.0 introduced support for top level await, so
@babel/plugin-syntax-top-level-await is no longer necessary.

PR-URL: nodejs#40394
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Trott
tools: remove @bable/plugin-syntax-class-properties
b39db95 
ESLint 8.0.0 makes the plugin unnecessary.

PR-URL: nodejs#40394
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Trott
tools: remove @babel/plugin-syntax-import-assertions
43c780e 
As of ESLint 8.0.0 at least, this plugin is unnecessary.

PR-URL: nodejs#40394
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Trott
tools: udpate @babel/eslint-parser
012152d 
Remove unused plugins and update @babel/eslint-parser

PR-URL: nodejs#40394
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Trott Trott force-pushed the eslint-update-8.0.0 branch from cf7749f to 012152d Compare October 12, 2021 01:38
@Trott
Copy link
Member Author

Trott commented Oct 12, 2021

Landed in 40db88b...012152d

@Trott Trott merged commit 012152d into nodejs:master Oct 12, 2021
@Trott Trott deleted the eslint-update-8.0.0 branch October 12, 2021 01:40
@Trott Trott removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 12, 2021
targos pushed a commit that referenced this pull request Oct 13, 2021
@Trott @targos
tools: fix ESLint update scripts
282b6eb 
Changes to the npm dependency in the core repo require changes to
update-eslint.sh and update-bable-eslint.sh.

PR-URL: #40394
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Oct 13, 2021
@Trott @targos
tools: prepare ESLint rules for 8.0.0 requirements
43b97c7 
PR-URL: #40394
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Oct 13, 2021
@Trott @targos
tools: update ESLint to 8.0.0
d9157aa 
PR-URL: #40394
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Oct 13, 2021
@Trott @targos
tools: remove @babel/plugin-syntax-top-level-await
d6a99b7 
ESLint 8.0.0 introduced support for top level await, so
@babel/plugin-syntax-top-level-await is no longer necessary.

PR-URL: #40394
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Oct 13, 2021
@Trott @targos
tools: remove @bable/plugin-syntax-class-properties
b72d693 
ESLint 8.0.0 makes the plugin unnecessary.

PR-URL: #40394
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Oct 13, 2021
@Trott @targos
tools: remove @babel/plugin-syntax-import-assertions
3611073 
As of ESLint 8.0.0 at least, this plugin is unnecessary.

PR-URL: #40394
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Oct 13, 2021
@Trott @targos
tools: udpate @babel/eslint-parser
50f91ab 
Remove unused plugins and update @babel/eslint-parser

PR-URL: #40394
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Oct 14, 2021
Merged
2 tasks
@aduh95 aduh95 mentioned this pull request Oct 14, 2021
Closed
@richardlau richardlau mentioned this pull request Oct 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes

@targos targos targos approved these changes

@aduh95 aduh95 aduh95 approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Trott @lpinca @targos @aduh95 @nodejs-github-bot @Mesteery