meta: consolidate duplicate AUTHORS entries for hassaanp#40391
Closed
Trott wants to merge 1 commit intonodejs:masterfrom
Closed
meta: consolidate duplicate AUTHORS entries for hassaanp#40391Trott wants to merge 1 commit intonodejs:masterfrom
Trott wants to merge 1 commit intonodejs:masterfrom
Conversation
Create a .mailmap entry to consolidate the two AUTHORS entries for hassaanp into a single entry.
nodejs-github-bot
added
the
meta
Member
Author
|
@hassaanp This removes your team.io email from AUTHORS and leaves your gmail.com address. If you'd prefer it the other way around, please leave a comment. Thanks! |
Contributor
|
Fast-track has been requested by @Trott. Please 👍 to approve. |
tniessen
approved these changes
Oct 10, 2021
Contributor
|
Please go ahead. Thanks |
Mesteery
added
the
author ready
Lxxyx
approved these changes
Oct 11, 2021
Lxxyx
added
the
commit-queue
github-actions
bot
removed
the
commit-queue
Contributor
|
Landed in 66da32c...0cc3720 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Oct 11, 2021
Create a .mailmap entry to consolidate the two AUTHORS entries for hassaanp into a single entry. PR-URL: #40391 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
targos
pushed a commit
that referenced
this pull request
Oct 13, 2021
Create a .mailmap entry to consolidate the two AUTHORS entries for hassaanp into a single entry. PR-URL: #40391 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
2 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create a .mailmap entry to consolidate the two AUTHORS entries for
hassaanp into a single entry.