test: fix typos in whatwg-webstreams explanations#40389
Closed
tniessen wants to merge 1 commit intonodejs:masterfrom
Closed
test: fix typos in whatwg-webstreams explanations#40389tniessen wants to merge 1 commit intonodejs:masterfrom
tniessen wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
needs-ci
Contributor
|
Fast-track has been requested by @tniessen. Please 👍 to approve. |
cjihrig
approved these changes
Oct 9, 2021
aduh95
approved these changes
Oct 9, 2021
aduh95
added
author ready
tniessen
added
the
commit-queue
github-actions
bot
removed
the
commit-queue
Contributor
Commit Queue failed- Loading data for nodejs/node/pull/40389 ✔ Done loading data for nodejs/node/pull/40389 ----------------------------------- PR info ------------------------------------ Title test: fix typos in whatwg-webstreams explanations (#40389) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch tniessen:test-typos-whatwg-webstreams-transfer-transfered -> nodejs:master Labels test, fast-track, author ready Commits 1 - test: fix typos in whatwg-webstreams explanations Committers 1 - GitHub PR-URL: https://github.com/nodejs/node/pull/40389 Reviewed-By: Colin Ihrig Reviewed-By: Antoine du Hamel ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/40389 Reviewed-By: Colin Ihrig Reviewed-By: Antoine du Hamel -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 09 Oct 2021 16:45:03 GMT ✔ Approvals: 2 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/40389#pullrequestreview-775593853 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/40389#pullrequestreview-775594008 ℹ This PR is being fast-tracked ✔ Last GitHub Actions successful ✖ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1324128655 |
github-actions
bot
added
the
commit-queue-failed
lpinca
approved these changes
Oct 9, 2021
tniessen
removed
the
commit-queue-failed
Trott
approved these changes
Oct 9, 2021
github-actions
bot
removed
the
request-ci
Collaborator
tniessen
added
the
commit-queue
github-actions
bot
removed
the
commit-queue
Contributor
|
Landed in 92090d3...8068f40 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Oct 10, 2021
PR-URL: #40389 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this pull request
Oct 13, 2021
PR-URL: #40389 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
2 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.