meta: consolidate AUTHORS entry for thw0rted#40387
Closed
Trott wants to merge 1 commit intonodejs:masterfrom
Closed
meta: consolidate AUTHORS entry for thw0rted#40387Trott wants to merge 1 commit intonodejs:masterfrom
Trott wants to merge 1 commit intonodejs:masterfrom
Conversation
Use a .mailmap entry to consolidate the two entries for thw0rted in AUTHORS into one entry.
Member
Author
|
@thw0rted This removes the users.noreply.github.com email from our AUTHORS file and leaves the gdit.com address. If you would prefer we do it the other way around, please leave a comment. Thanks! |
tniessen
approved these changes
Oct 9, 2021
Contributor
|
Fast-track has been requested by @Trott. Please 👍 to approve. |
cjihrig
approved these changes
Oct 9, 2021
lpinca
approved these changes
Oct 9, 2021
Contributor
|
Landed in ac4f5e2...a3c0713 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Oct 9, 2021
Use a .mailmap entry to consolidate the two entries for thw0rted in AUTHORS into one entry. PR-URL: #40387 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Oct 13, 2021
Use a .mailmap entry to consolidate the two entries for thw0rted in AUTHORS into one entry. PR-URL: #40387 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a .mailmap entry to consolidate the two entries for thw0rted in
AUTHORS into one entry.