doc: esm resolver spec refactoring for deprecations#40314
Closed
guybedford wants to merge 1 commit intonodejs:masterfrom
Closed
doc: esm resolver spec refactoring for deprecations#40314guybedford wants to merge 1 commit intonodejs:masterfrom
guybedford wants to merge 1 commit intonodejs:masterfrom
Conversation
3bb3298 to
0a40695
Compare
Contributor
|
Could you add the refs to the PR that added the runtime deprecations please? That would help reviewing this. Also we should probably add |
Contributor
Author
|
@aduh95 the one reference is in the description, the other reference is the PR you did for the index deprecations I believe, is that the one you are after? |
aduh95
approved these changes
Oct 5, 2021
Contributor
aduh95
left a comment
There was a problem hiding this comment.
Thanks for reminding me, I've added Refs: to the OP so it's added to the commit message on landing.
jasnell
approved these changes
Oct 7, 2021
Contributor
Author
|
Landed in ccee352. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR integrates the current ES module resolver deprecations into the specification assuming those deprecations have all been runtime deprecated.
Specifically:
"exports"field. This assumes the runtime deprecation of the index lookups deprecation, such that the main can just be resolved directly as a subpath without any statting when the exports fields is not declared by a package.In the process I also spotted two simple spec editorial changes included here as well.
@nodejs/modules
Refs: #37206
Refs: #40117