Closed
Conversation
Contributor
|
Fast-track has been requested by @targos. Please 👍 to approve. |
cjihrig
approved these changes
Oct 4, 2021
Member
|
cc @nodejs/security @nodejs/security-wg |
tniessen
approved these changes
Oct 4, 2021
BethGriggs
approved these changes
Oct 4, 2021
vdeturckheim
approved these changes
Oct 4, 2021
targos
added
doc
github-actions
bot
removed
the
request-ci
Collaborator
lpinca
approved these changes
Oct 4, 2021
21 tasks
Collaborator
Trott
approved these changes
Oct 5, 2021
juanarbol
approved these changes
Oct 5, 2021
Trott
added
the
commit-queue
github-actions
bot
removed
the
commit-queue
Contributor
|
Landed in cbd61c9...658612b |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Oct 5, 2021
Fixes: #40306 PR-URL: #40308 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Vladimir de Turckheim <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]>
Contributor
|
@targos how should this be cherry-picked into v16? Can I leave out the v14 and v12 changes from the commit? |
danielleadams
pushed a commit
that referenced
this pull request
Oct 5, 2021
Fixes: #40306 PR-URL: #40308 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Vladimir de Turckheim <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]>
24 tasks
Member
Author
|
@danielleadams yes, that seems good to me! |
This was referenced Oct 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #40306