build: check for duplicates in new AUTHORS entries#40264
Closed
Trott wants to merge 2 commits intonodejs:masterfrom
Closed
build: check for duplicates in new AUTHORS entries#40264Trott wants to merge 2 commits intonodejs:masterfrom
Trott wants to merge 2 commits intonodejs:masterfrom
Conversation
When the GitHub Action adds new entries to the AUTHORS file, have it also flag new entries that might be duplicates.
nodejs-github-bot
added
the
meta
Member
Author
|
I imagine the code here can be simplified a bit, or at least organized a bit better (with more clear comments). Like, the |
jasnell
approved these changes
Sep 30, 2021
tniessen
approved these changes
Oct 1, 2021
Trott
added
author ready
github-actions
bot
removed
the
request-ci
This comment has been minimized.
This comment has been minimized.
Collaborator
Trott
added
the
commit-queue
github-actions
bot
removed
the
commit-queue
Contributor
|
Landed in 1811396...2a3a9b8 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Oct 3, 2021
When the GitHub Action adds new entries to the AUTHORS file, have it also flag new entries that might be duplicates. PR-URL: #40264 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
22 tasks
targos
pushed a commit
that referenced
this pull request
Oct 4, 2021
When the GitHub Action adds new entries to the AUTHORS file, have it also flag new entries that might be duplicates. PR-URL: #40264 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
This was referenced Oct 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the GitHub Action adds new entries to the AUTHORS file, have it
also flag new entries that might be duplicates.