vm: add support for import assertions in dynamic imports by aduh95 · Pull Request #40249 · nodejs/node

aduh95 · 2021-09-28T20:41:08Z

No description provided.

doc/api/vm.md

aduh95 · 2021-10-01T08:54:17Z

Ping @nodejs/vm @nodejs/modules for reviews.

bmeck

Assert enforcement of spec for "type": "json" isn't in place but this is still experimental and I honestly don't have a clean way to enforce it even if we wanted to. We could treat this as a power/debugging tool which often lies outside of the spec? Seems fine for now but should revisit decision before unflagging.

nodejs-github-bot · 2021-10-01T14:18:00Z

CI: https://ci.nodejs.org/job/node-test-pull-request/40123/

GeoffreyBooth · 2021-10-01T17:04:17Z

In #40250 (comment) I asked if this could wait until that PR lands, or if this could land as part of that PR. There’s an unresolved discussion there about when and whether import assertions should be passed around between internal functions, which is what this PR adds; so it seems premature to land this until we’ve settled that question.

aduh95 · 2021-10-02T12:23:28Z

@GeoffreyBooth I've opened this PR to separate the changes in vm from the changes required to add support to the ESM loader. My reasoning was:

It avoids the discussion being limited to discussing loader implementation and JSON modules in particular. As a proof, the discussion in this thread has been productive, folks have made great suggestions that indeed improves the PR.
No matter what happens with the other PRs, we need to fix at some point the support in vm (currently it supports assertions only for static imports, not dynamic ones, which was almost certainly an oversight of vm: add import assertion support #37176).
Landing this would also simplify reviewing the other PRs.
If none of my other PRs land, I'd like to at least land this so all the work I put into it is not lost.
Landing this doesn't mean that no other changes can be made relative to import assertions support in vm, the ES modules support there is still experimental and behind a flag (well two flags even: --experimental-vm-modules --harmony-import-assertions).

That being said, of course I'm OK waiting if there are concerns, but if there are none, I'd rather have it landed, and a future PR can change the implementation again if it turns out being necessary.

guybedford

Seems like a nice simple change, and since VM doesn't relate to cache keying questions at all I don't see any reason not to land this.

devsnek · 2021-10-04T17:01:40Z

src/module_wrap.cc

+  Local<Object> assertions =
+    Object::New(isolate, v8::Null(env->isolate()), nullptr, nullptr, 0);
+  for (int i = 0; i < import_assertions->Length(); i += 2) {
+    assertions
+        ->Set(env->context(),
+              Local<String>::Cast(import_assertions->Get(env->context(), i)),
+              Local<Value>::Cast(import_assertions->Get(env->context(), i + 1)))
+        .ToChecked();
+  }


if possible it might be good to dedupe this code with the static import path so they stay consistent

Done in adf6993.

nodejs-github-bot · 2021-10-05T20:33:19Z

CI: https://ci.nodejs.org/job/node-test-pull-request/40164/

GeoffreyBooth

I discussed with @aduh95; my concern about the function signature was whether the assertions would become part of the cache key. He tells me that he thinks that won’t be the case, in this PR at least. So I think this should be fine to land.

nodejs-github-bot · 2021-10-05T21:53:58Z

CI: https://ci.nodejs.org/job/node-test-pull-request/40168/

nodejs-github-bot · 2021-10-05T22:38:34Z

CI: https://ci.nodejs.org/job/node-test-pull-request/40170/

nodejs-github-bot · 2021-10-06T07:30:13Z

CI: https://ci.nodejs.org/job/node-test-pull-request/40175/

nodejs-github-bot · 2021-10-09T07:31:29Z

CI: https://ci.nodejs.org/job/node-test-pull-request/40226/

github-actions · 2021-10-09T08:44:55Z

Landed in 879ff77...08ffbd1

PR-URL: #40249 Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>

Notable changes: deps: * upgrade npm to 8.1.0 (npm team) #40463 doc: * deprecate (doc-only) http abort related (dr-js) #36670 vm: * (SEMVER-MINOR) add support for import assertions in dynamic imports (Antoine du Hamel) #40249 PR-URL: #40504

Notable Changes: Experimental ESM Loader Hooks API: Node.js ESM Loader hooks have been consolidated to represent the steps involved needed to facilitate future loader chaining: 1. `resolve`: `resolve` [+ `getFormat`] 2. `load`: `getFormat` + `getSource` + `transformSource` For consistency, `getGlobalPreloadCode` has been renamed to `globalPreload`. A loader exporting obsolete hook(s) will trigger a single deprecation warning (per loader) listing the errant hooks. Contributed by Jacob Smith, Geoffrey Booth, and Bradley Farias - #37468 Other Notable Changes: deps: * upgrade npm to 8.1.0 (npm team) #40463 doc: * deprecate (doc-only) http abort related (dr-js) #36670 vm: * (SEMVER-MINOR) add support for import assertions in dynamic imports (Antoine du Hamel) #40249 PR-URL: #40504

Ashoat · 2022-05-20T21:48:32Z

Running Node 16.13.2, I see the following when I try to specify an import assertion on a dynamic import():

    const importedJSON = await import(`../../${path}`, {
                                                     ^

SyntaxError: Unexpected token ','

I think Node 16.3.2 includes this commit, but I'm guessing there's another one that's necessary in order for this to work?

Thanks in advance for any response, and sorry for pinging the PR like this.

aduh95 · 2022-05-20T22:25:49Z

You need to use the --harmony-import-assertions CLI flag, or even better update to Node.js v16.15+.

aduh95 requested a review from devsnek September 28, 2021 20:41

nodejs-github-bot added needs-ci PRs that need a full CI run. vm Issues and PRs related to the vm subsystem. labels Sep 28, 2021

devsnek reviewed Sep 28, 2021

View reviewed changes

doc/api/vm.md Outdated Show resolved Hide resolved

aduh95 commented Sep 28, 2021

View reviewed changes

doc/api/vm.md Outdated Show resolved Hide resolved

aduh95 mentioned this pull request Sep 28, 2021

esm: add support for JSON import assertion #40250

Closed

aduh95 added the semver-minor PRs that contain new features and should be released in the next minor version. label Sep 28, 2021

aduh95 requested a review from devsnek September 28, 2021 22:48

VoltrexKeyva reviewed Sep 29, 2021

View reviewed changes

doc/api/vm.md Outdated Show resolved Hide resolved

targos reviewed Sep 29, 2021

View reviewed changes

doc/api/vm.md Outdated Show resolved Hide resolved

doc/api/vm.md Outdated Show resolved Hide resolved

doc/api/vm.md Show resolved Hide resolved

bmeck approved these changes Oct 1, 2021

View reviewed changes

aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Oct 1, 2021

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 1, 2021

github-actions bot mentioned this pull request Oct 2, 2021

CI Reliability 2021-10-02 nodejs/reliability#75

Open

19 tasks

This was referenced Oct 3, 2021

CI Reliability 2021-10-03 nodejs/reliability#76

Open

CI Reliability 2021-10-04 nodejs/reliability#77

Open

guybedford approved these changes Oct 4, 2021

View reviewed changes

devsnek approved these changes Oct 4, 2021

View reviewed changes

github-actions bot mentioned this pull request Oct 5, 2021

CI Reliability 2021-10-05 nodejs/reliability#78

Open

21 tasks

aduh95 added 2 commits October 5, 2021 19:23

vm: add support for import assertions in dynamic imports

085b12c

fixup! vm: add support for import assertions in dynamic imports

adf6993

aduh95 force-pushed the vm-import-assertion-dynamic branch from 9c2964f to adf6993 Compare October 5, 2021 17:31

aduh95 added request-ci Add this label to start a Jenkins CI on a PR. and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Oct 5, 2021

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 5, 2021

GeoffreyBooth approved these changes Oct 5, 2021

View reviewed changes

github-actions bot mentioned this pull request Oct 6, 2021

CI Reliability 2021-10-06 nodejs/reliability#79

Open

24 tasks

This was referenced Oct 7, 2021

CI Reliability 2021-10-07 nodejs/reliability#80

Open

CI Reliability 2021-10-08 nodejs/reliability#81

Open

CI Reliability 2021-10-09 nodejs/reliability#82

Open

aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 9, 2021

github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 9, 2021

github-actions bot closed this Oct 9, 2021

aduh95 deleted the vm-import-assertion-dynamic branch October 9, 2021 08:59

This was referenced Oct 10, 2021

CI Reliability 2021-10-10 nodejs/reliability#83

Open

CI Reliability 2021-10-11 nodejs/reliability#84

Open

CI Reliability 2021-10-13 nodejs/reliability#85

Open

BethGriggs mentioned this pull request Oct 14, 2021

2021-10-19, Version 17.0.0 (Current) #40119

Merged

2 tasks

richardlau mentioned this pull request Oct 18, 2021

v16.12.0 proposal #40504

Merged

mischnic mentioned this pull request Apr 11, 2022

Drop Node 12 in tests and add Node 16 parcel-bundler/parcel#7935

Merged

1 task

Uh oh!

Conversation

aduh95 commented Sep 28, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aduh95 commented Oct 1, 2021

Uh oh!

bmeck left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Oct 1, 2021

Uh oh!

GeoffreyBooth commented Oct 1, 2021

Uh oh!

aduh95 commented Oct 2, 2021

Uh oh!

guybedford left a comment

Choose a reason for hiding this comment

Uh oh!

devsnek Oct 4, 2021

Choose a reason for hiding this comment

Uh oh!

aduh95 Oct 5, 2021

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Oct 5, 2021

Uh oh!

GeoffreyBooth left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Oct 5, 2021

Uh oh!

nodejs-github-bot commented Oct 5, 2021

Uh oh!

nodejs-github-bot commented Oct 6, 2021

Uh oh!

nodejs-github-bot commented Oct 9, 2021

Uh oh!

github-actions bot commented Oct 9, 2021

Uh oh!

Ashoat commented May 20, 2022

Uh oh!

aduh95 commented May 20, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants