Skip to content

repl: fix and extend require/import tab complete#40216

Merged
nodejs-github-bot merged 1 commit intonodejs:masterfrom
Mesteery:repl-fix-require-import-auto-complete
Nov 25, 2021
Merged

repl: fix and extend require/import tab complete#40216
nodejs-github-bot merged 1 commit intonodejs:masterfrom
Mesteery:repl-fix-require-import-auto-complete

Conversation

@Mesteery
Copy link
Contributor

@Mesteery Mesteery commented Sep 25, 2021

No description provided.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. repl Issues and PRs related to the REPL subsystem. labels Sep 25, 2021
@targos
Copy link
Member

targos commented Sep 26, 2021

@nodejs/repl

BridgeAR
BridgeAR approved these changes Nov 4, 2021
View reviewed changes
Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

@Mesteery Mesteery added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 4, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 4, 2021
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 4, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/40719/

This was referenced Nov 5, 2021
Open
Open
Open
Open
@joyeecheung joyeecheung mentioned this pull request Nov 8, 2021
Closed
@Mesteery Mesteery added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Nov 8, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 8, 2021
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 8, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/40788/

This was referenced Nov 9, 2021
Open
Open
Open
@Mesteery Mesteery force-pushed the repl-fix-require-import-auto-complete branch from 96b02bb to 4100f5f Compare November 11, 2021 17:53
@Mesteery Mesteery added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 11, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 11, 2021
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 11, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/40830/

@Mesteery Mesteery added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 11, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 11, 2021
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 11, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/40837/

@github-actions github-actions bot mentioned this pull request Nov 12, 2021
Open
35 tasks
@Mesteery Mesteery added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 12, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 12, 2021
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 12, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/40843/

@Mesteery Mesteery added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 12, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 12, 2021
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 12, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/40847/

@Mesteery Mesteery added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 12, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 12, 2021
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 12, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/40850/

@Mesteery Mesteery added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 12, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 12, 2021
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 12, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/40853/

@github-actions github-actions bot mentioned this pull request Nov 13, 2021
Open
31 tasks
@Mesteery Mesteery added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 13, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 13, 2021
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 13, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/40862/

This was referenced Nov 14, 2021
Open
Open
Open
Open
Open
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 24, 2021
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 25, 2021
@nodejs-github-bot nodejs-github-bot merged commit af28345 into nodejs:master Nov 25, 2021
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 25, 2021

Landed in af28345

targos pushed a commit that referenced this pull request Nov 26, 2021
@Mesteery @targos
repl: fix and extend require/import tab complete
1555dbd 
PR-URL: #40216
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Nov 26, 2021
Merged
danielleadams pushed a commit that referenced this pull request Jan 30, 2022
@Mesteery @danielleadams
repl: fix and extend require/import tab complete
1d8a496 
PR-URL: #40216
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@Mesteery @danielleadams
repl: fix and extend require/import tab complete
370bfda 
PR-URL: #40216
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. repl Issues and PRs related to the REPL subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Mesteery @targos @nodejs-github-bot @jasnell @BridgeAR @aduh95