src: remove usage of AllocatedBuffer from crypto_common.cc#40213
Closed
RaisinTen wants to merge 1 commit intonodejs:masterfrom
Closed
src: remove usage of AllocatedBuffer from crypto_common.cc#40213RaisinTen wants to merge 1 commit intonodejs:masterfrom
AllocatedBuffer from crypto_common.cc#40213RaisinTen wants to merge 1 commit intonodejs:masterfrom
Conversation
Signed-off-by: Darshan Sen <[email protected]>
nodejs-github-bot
added
c++
This comment has been minimized.
This comment has been minimized.
jasnell
approved these changes
Sep 25, 2021
Collaborator
RaisinTen
added
the
author ready
This was referenced Sep 26, 2021
XadillaX
approved these changes
Sep 27, 2021
18 tasks
XadillaX
pushed a commit
that referenced
this pull request
Sep 28, 2021
Signed-off-by: Darshan Sen <[email protected]> PR-URL: #40213 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Khaidi Chu <[email protected]>
Contributor
|
Landed in 2caa308 |
RaisinTen
deleted the
src/remove-usage-of-AllocatedBuffer-from-crypto_common.cc
branch
This was referenced Sep 29, 2021
targos
pushed a commit
that referenced
this pull request
Oct 4, 2021
Signed-off-by: Darshan Sen <[email protected]> PR-URL: #40213 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Khaidi Chu <[email protected]>
21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Darshan Sen [email protected]