doc: add version when diagnostics_channel APIs were added#40208
Closed
Flarna wants to merge 1 commit intonodejs:masterfrom
Closed
doc: add version when diagnostics_channel APIs were added#40208Flarna wants to merge 1 commit intonodejs:masterfrom
Flarna wants to merge 1 commit intonodejs:masterfrom
Conversation
Flarna
force-pushed
the
doc_diag-channel_created
branch
2 times, most recently
from
3615a52 to
d1e4736
Compare
Add a yaml section to document when diagnostics_channel APIs were introduced.
Flarna
force-pushed
the
doc_diag-channel_created
branch
from
d1e4736 to
b70b0d6
Compare
Flarna
added
the
author ready
Member
|
I'm not quite sure how the module scoped |
Qard
approved these changes
Sep 24, 2021
Member
|
As far as I understand it, the introduced_in thing is for telling the version changer thing at the top of the page what version to start its range at. It doesn't seem to support features introduced partway through the life of one version and then backported partway through the life of another. |
tniessen
approved these changes
Sep 24, 2021
Member
Author
I don't know either. it's not visible if you browse the docs. At least the version matches so seem to be fine. |
jasnell
approved these changes
Sep 25, 2021
Contributor
|
Fast-track has been requested by @jasnell. Please 👍 to approve. |
cjihrig
approved these changes
Sep 25, 2021
Flarna
added
the
commit-queue
github-actions
bot
removed
the
commit-queue
Contributor
|
Landed in ae876d4...b0ef080 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Sep 25, 2021
Add a yaml section to document when diagnostics_channel APIs were introduced. PR-URL: #40208 Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
targos
pushed a commit
that referenced
this pull request
Oct 4, 2021
Add a yaml section to document when diagnostics_channel APIs were introduced. PR-URL: #40208 Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Mesteery
added
the
diagnostics_channel
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a yaml section to document when diagnostics_channel APIs were introduced.
Refs.: #34895