src: move ToUSVString() to node_util.cc#40204
Closed
XadillaX wants to merge 1 commit intonodejs:masterfrom
Closed
Conversation
Since `toUSVString()` was exposed in `util` as a public API, not only for internal `url` any more.
nodejs-github-bot
added
c++
jasnell
approved these changes
Sep 25, 2021
cjihrig
approved these changes
Sep 25, 2021
Collaborator
Lxxyx
approved these changes
Sep 26, 2021
targos
added
the
author ready
XadillaX
added a commit
that referenced
this pull request
Sep 26, 2021
Since `toUSVString()` was exposed in `util` as a public API, not only for internal `url` any more. PR-URL: #40204 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Zijian Liu <[email protected]>
Contributor
Author
|
Landed in 0e561de |
targos
pushed a commit
that referenced
this pull request
Oct 4, 2021
Since `toUSVString()` was exposed in `util` as a public API, not only for internal `url` any more. PR-URL: #40204 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Zijian Liu <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since
toUSVString()was exposed inutilas a public API, not onlyfor internal
urlany more.