tools: re-implement lint-md without unified-args by Trott · Pull Request #40180 · nodejs/node

Trott · 2021-09-22T20:46:45Z

unified-args ignores settings in the preset, expecting them to be in
remarkrc files or passed on the command line instead. Realizing that
we always send the same configuration options via the command-line
anyway, this removes unified-args. This means the preset settings are
now respected and it removes nearly over 28000 lines of code in the resulting
rollup file.

I wasn't sure I was going to want to keep rollup so I started
re-implementing this without it, but ended up putting a minimal rollup
back as it still saves about 90000 lines of code vs. checking in
node_modules.

nodejs-github-bot · 2021-09-23T04:47:08Z

CI: https://ci.nodejs.org/job/node-test-pull-request/40038/

`unified-args` ignores settings in the preset, expecting them to be in remarkrc files or passed on the command line instead. Realizing that we always send the same configuration options via the command-line anyway, this removes `unified-args`. This means the preset settings are now respected and it removes nearly 30000 lines of code in the resulting rollup file. I wasn't sure I was going to want to keep rollup so I started re-implementing this without it, but ended up putting a minimal rollup back as it still saves about 90000 lines of code vs. checking in `node_modules`.

nodejs-github-bot · 2021-09-23T06:31:41Z

CI: https://ci.nodejs.org/job/node-test-pull-request/40042/

nodejs-github-bot · 2021-09-23T10:28:24Z

CI: https://ci.nodejs.org/job/node-test-pull-request/40046/

github-actions · 2021-09-25T03:51:54Z

Landed in 8006586...8d83c47

`unified-args` ignores settings in the preset, expecting them to be in remarkrc files or passed on the command line instead. Realizing that we always send the same configuration options via the command-line anyway, this removes `unified-args`. This means the preset settings are now respected and it removes nearly 30000 lines of code in the resulting rollup file. I wasn't sure I was going to want to keep rollup so I started re-implementing this without it, but ended up putting a minimal rollup back as it still saves about 90000 lines of code vs. checking in `node_modules`. PR-URL: #40180 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]>

Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 22, 2021

Trott mentioned this pull request Sep 22, 2021

tools: implement markdown formatting #40181

Merged

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 22, 2021