Conversation
nodejs-github-bot
added
doc
tniessen
approved these changes
Sep 20, 2021
jasnell
approved these changes
Sep 20, 2021
lpinca
added
the
commit-queue
github-actions
bot
added
commit-queue-failed
Contributor
Commit Queue failed- Loading data for nodejs/node/pull/40161 ✔ Done loading data for nodejs/node/pull/40161 ----------------------------------- PR info ------------------------------------ Title doc: fix typos in http.md (#40161) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch lpinca:fix/typo -> nodejs:master Labels http, doc Commits 1 - doc: fix typos in http.md Committers 1 - Luigi Pinca PR-URL: https://github.com/nodejs/node/pull/40161 Reviewed-By: Tobias Nießen Reviewed-By: James M Snell Reviewed-By: Michael Dawson ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/40161 Reviewed-By: Tobias Nießen Reviewed-By: James M Snell Reviewed-By: Michael Dawson -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - doc: fix typos in http.md ℹ This PR was created on Mon, 20 Sep 2021 09:32:10 GMT ✔ Approvals: 3 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/40161#pullrequestreview-758623968 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/40161#pullrequestreview-758697511 ✔ - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/40161#pullrequestreview-758748071 ✔ Last GitHub Actions successful ℹ Green GitHub Actions CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1262934779 |
lpinca
added a commit
that referenced
this pull request
Sep 22, 2021
PR-URL: #40161 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Member
Author
|
Landed in e1bca10. |
targos
pushed a commit
that referenced
this pull request
Oct 4, 2021
PR-URL: #40161 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reach -> reached.
closed->close.